I'm developing a project where the cliente wants to change logo and background everytime he wants logo is covered by system.module, but background isn't. I found out this module, but I'm using two themes, one for normal users and another one for admin users (garland).

I set up background.module, and set background on normal users theme and I tested that theme, all was ok, but when I logged in with the admin user, I discover that the background also was changed on the admin theme.

After see the code, y discover that module aren't using a way to link background to theme modified, instead is using ONLY ONE generic variable: background_file, that means that doesn't matter wich theme you modified, all themes will be affected.

I fixed this already.

Also, the logic involved on selecting the current user's theme has a little error, was calling $vars['user']->theme instead of $user->theme, I fixed that too.

Please review the patch file attached.

Thanks for the module.

Daniel Alvarado

CommentFileSizeAuthor
background.patch1.45 KBopteronmx

Comments

tonyn’s picture

tonyn commented

Looks good Daniel. Going to go ahead and commit this. Tested.

rm'd the comment. Also going to include a path fix I did.

tonyn’s picture

tonyn commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

calefilm’s picture

calefilm commented

I just downloaded this module. When I configure the SKY theme for instance to show this image in the background, my other themes are affected without me configuring them separately.

waltf’s picture

waltf commented

yup, still affects all themes including my mobile theme :(
can't we write the background.css to the theme path, instead of the site path (default/files)?
I might give it a shot, but my php isn't what it should be ;)