theme_get_setting() tries to use a global variable which doesn't exist anymore
David_Rothstein - November 5, 2009 - 21:45
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | theme system |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed |
Description
People keep trying to slip stuff referring to the global $custom_theme variable into Drupal even though that global variable no longer exists... probably it's related to the fact that we haven't gotten around to documenting the change from #553944: Allow modules to specify per-page custom themes in hook_menu() yet :)
In this case, I'm not even sure what the code was trying to use it for. Whenever drupal_theme_initialize() is called, the global $theme_key gets set to the actual theme that is going to be used for the current page, so as far as I can tell, that is all we would ever need to check here.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| get-rid-of-custom-theme-global.patch | 717 bytes | Idle | Failed: 14684 passes, 9 fails, 336 exceptions | View details | Re-test |
#1
The last submitted patch failed testing.
#2
I'm pretty sure those test failures aren't for real. Resubmitting.
#3
Committed to CVS HEAD. Thanks David.
#4
Automatically closed -- issue fixed for 2 weeks with no activity.