Jump to:
| Project: | Organic groups |
| Version: | 6.x-2.2 |
| Component: | og_access.module |
| Category: | bug report |
| Priority: | major |
| Assigned: | Unassigned |
| Status: | active |
| Issue tags: | og-wtf |
Issue Summary
I have tried og 6.x-2.0 and the latest dev version.
On the admin/og/og_access page visibility of posts is set to "visible only within the targeted groups". Despite the note that OG admins always see the checkbox for making a post public, that does not appear to be working in my setup. OG managers and admins can edit group posts but are missing the make public checkbox.
Under private groups the setting is group administrator chooses whether group homepage and audience are private or not. Default to public.
I cannot get the check box to make public appear for group manager or admin. I have spent several hours searching through the issues queue and other posts without finding a solution to my problem. Any help would be appreciated.
Thanks,
Izzy
Comments
#1
Having looked into this further I am inclined to think this is a bug.
Unless the user is assigned to a site-wide role that includes permissions to administer og they do not see the "public" check box on posts. I thought that group admins would see this check box as it says on the admin/og/og_access page.
Any suggestions on how to resolve this would be appreciated. Thanks,
Izzy
#2
I ran this evening in the same problem. No check box for public
#3
bump
I am wondering if anyone has suggestions on how to make it possible for group managers and admins to be able to make a group post public? Thanks,
Izzy
#4
Same problem for me, with D6.15, og 6.20 with these modules installed: og block visibiliy 1.2, og calendar 1.0, og contact 1x dev, og content type admin 1.2, og forum 2.2, hide membership 1.0-alpha1, views-extra 1.0, group access control 2.0, group notifications 2.0, groups perms 1.x dev.
I've tried turning off most of these modules and still no public check box.
I traced og_access.module working its way through with firep(): in og_access_alter_nongroup_form I find that the following code is run when the form is loaded:
switch ($vis) {
---snip----
case OG_VISIBLE_CHOOSE_PRIVATE:
// this is run
$form['og_nodeapi']['visible']['og_public'] = array(
'#type' => 'checkbox',
'#title' => t('Public'),
'#default_value' => isset($node->og_public) ? $node->og_public : 0,
'#description' => t('Show this post to everyone, or only to members of the groups checked above. Posts without any groups are always public.'),
'#weight' => 2,
);
break;
}
if (count($form['og_nodeapi']['visible']) > 1) {
// this is run
$form['og_nodeapi']['#type'] = 'fieldset';
$form['og_nodeapi']['#title'] = t('Groups');
$form['og_nodeapi']['#collapsible'] = TRUE;
$form['og_nodeapi']['#collapsed'] = $selected_groups ? TRUE : FALSE;
}
however when I look at the form with drupalforFirebug, there is no og_nodeapi or "Public" anywhere!
#5
I need this feature as well - similar issue here http://drupal.org/node/178811
You can enable the Public checkbox using OG Access configuration (Visibility chosen by Author...), however as I have a lot of groups it slows down content creation form to over 30 seconds while it looks up all possible groups.
Is it possible to have a permission which enables the public checkbox but doesn't look up all the groups and slow down the form?
This will not be a good user experience for administrators.
Thanks
#6
Slowing down for a large number of groups, and failing to show the public checkbox even for admins happens in the same if clause in og_access.module. Some recoding should be done. I just posted a comment about this in a (fixed) issue: http://drupal.org/node/431944. Which thread would be the right one to continue with this?
#7
Yes this bug is still there, I don't see a public selectbox when making a new node in a private group.
Actually I can make a posts public by simply not selecting any groups, but this is certainly not intuitive! And I do see the box when I don't select any groups (so it is made public) and then re-edit the node. Also (another bug) when I re-edit a node and select an audience again - and forget to turn off the public checkbox - it stays public and I cannot make it private anymore!
I think that the checkbox is needed here and needs a same conditional markup trick as when making a group (that all audiences grey out if you select public).
btw. thanks for this beautiful module!!
Greets Bas
#8
I have a similar issue. First you have a node that is not assigned to a group. You edit and click on a group, the public checkbox is already checked, wonderful. Then you save and click edit again, the public checkbox disappears and if you add it to another group all of a sudden it makes it private.
#9
ya its worse than i thought, you dont even have to change anything, once you resave the node without the public checkbox it makes it private, that is definitely a bug
#10
I dont understand the need for this logic:
if (!empty($selected_groups)) {foreach ($selected_groups as $gid) {
$group_node = new stdClass();
$group_node->nid = $gid;
og_load_group($group_node);
if (!empty($group_node->og_private)) {
// Set visibility to the appropriate private option.
$vis = variable_get('og_visibility', 0) == OG_VISIBLE_GROUPONLY ? OG_VISIBLE_GROUPONLY : OG_VISIBLE_CHOOSE_PRIVATE;
break;
}
}
}
This is what kills the public option. To me it shouldnt matter if the group is private or not. Some editors want to make content public but tag it with groups (pub or private) so that the content shows up in those group areas. I don't see why we should force a certain visibility here, I would suggest we just kill this section so that the editor can decide with the public checkbox as to whether or not a node is viewable outside the group.
#11
This is also an issue in the Drupal 7 1.0 release! The 6.x branch worked flawlessly for me!
Related bug for Drupal 7: #979614: og_access does not work! Nid and Gid confusion
#12
subscribe
#13
subscribing
#14
Is this being adressed by anyone?
#15
Still no news on this subject? Or anyone one that can guide so i can alter it myself? I have the time, but too little indepth knowledge of this module.
#16
Adding to list of strange OG behaviors in need of correction.
#17
Here is an update on what I am finding using og-6x-2.2
If a user is a member of more than one group and only admin in one or some of those groups on creating a new post the audience select boxes are visible but the public select box is not visible.
On re-editing the post, if it is for a group in which the user is an admin the public checkbox is now visible and shows as checked but can be unchecked. So this would appear to be working in that group admins can make posts public or not (at least on re-edit).
What is needed is for users who are admins in some groups to be able to see on create new posts a greyed out and checked public box. When/if they select a group in which they are an admin the public check box should no longer be greyed out. This is the behaviour og admins see. Someone may have a good idea of where to find the logic statement for this.
I am reducing the priority from critical to major and tempted to reduce it further to normal.
Thanks,
Izzy
#18
I am also changing title of this issue to be a little more clear.
#19
sorry for extra comments; making title more clear.