Compatibility with AJAX Comments

neochief - November 6, 2009 - 00:48
Project:Comment Notify
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hello, Greg.

I found that recent update of my module AJAX Comments affects on Comment Notify functioning. The reason is that AJAX Comments modifies some of the comment form elements to allow safe and fast ajax submissions. One of this elements is 'nid', which converted from "value" to "hidden" FAPI element. Comment Notify threats 'nid' value only as "value" type and can't grab 'nid' parameter from the form, which completely disable comment notifications.

The solution is to check either "#value" is accessible, and if it's not, try to grab "#default_value" from the 'nid' element.

Please, take a look at the patch. Thanks.

AttachmentSize
cn_ac.patch578 bytes

#1

greggles - November 6, 2009 - 23:08
Status:active» fixed

And done - http://drupal.org/cvs?commit=285288

Thanks, neochief!

#2

System Message - November 20, 2009 - 23:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.