Posted by sdrycroft on November 6, 2009 at 11:55am
Jump to:
| Project: | Comment Upload |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
I've just installed both the 6.x-dev and 6.x-1 release of this module and have found that neither of them work. When the preview button is clicked using either of the two versions, nothing happens, the page reloads without a preview. I'm pleased to say that the CVS version does work for me (although how stable/suitable it is, I don't know). All I'm asking for is a notice on the module's front page that states that the 6.x versions do not work.
Comments
#1
Sorry, not sure why I marked that as Critical, it's clearly just "Normal" (doesn't cause any white screens, just prevents submission of comments).
#2
Do you use the English locale on your website? If not, you encountered the issue fixed by http://cvs.drupal.org/viewvc/drupal/contributions/modules/comment_upload..., but the fix somehow did not propagate to the 6.x-1.x-dev archive.
BTW: None of the current archives (alphas and dev) are suitable for use on production sites.
#3
I believe this fixes the problem.
--- comment_upload.broken/comment_upload.install 2010-01-04 15:41:07.903961271 -0600
+++ comment_upload/comment_upload.install 2009-02-01 14:06:40.000000000 -0600
@@ -235,7 +235,7 @@
db_create_table($ret, 'comment_upload', $schema['comment_upload']);
if (substr($db_url, 0, 5) == 'mysql') {
- $max_file_id = db_result(db_query("SELECT MAX(fid) FROM files"));
+ $max_file_id = db_result(db_query("SELECT MAX(fid) FROM {files}"));
$offset = $max_file_id + 1;
db_query("INSERT INTO {files} (fid, uid, filename, filepath, filemime, filesize, status, timestamp) SELECT cuf.fid + %d, c.uid, cuf.filename, cuf.filepath, cuf.filemime, cuf.filesize, 1, c.timestamp FROM {comment_upload_files} cuf INNER JOIN {comments} c ON cuf.cid = c.cid", $offset);
$max_file_id = db_result(db_query("SELECT MAX(fid) FROM {files}"));
#4
#5
I am new to Drupal and do not know exactly what I should do with your fix. I have the Comment upload 6.x-1.0-alpha5 installed in my modules folder. Is your "Fix" that I open comment_upload.install in a text editor and replace the line
$max_file_id = db_result(db_query("SELECT MAX(fid) FROM files"));
with the line
$max_file_id = db_result(db_query("SELECT MAX(fid) FROM {files}"));
Save the file, and then run update.php?
Since I already have Comment upload 6.x-1.0-alpha5 installed, do I need to do something else first?
I would like to know how to apply this fix correctly, so I do not create any other problems
Thanks for any assistance
#6
I dont think that this is the problem.
it has to do be somewhere in the hook_comment process...
#7
I fail to see how an update hook could cause trouble on a fresh install. (The update is broken though).
#8
Is there actually any way to get comment upload to work? Things are getting very confusing. Latest dev (01.12-09) still does not fix the preview issue and when I try to go back to the last working version (cvs) the module completely gets disabled from the module page with an incompatibility warning for D6.15 (not tried with a fresh install yet).
Such a pitty... but somehow I start being afraid that after so much time we will never see a really usable version.
#9
The module is essentially unmaintained. Netaustin, dww and I only care for it to work on Drupal.org itself.
#10
Thanks a lot for the clear statement. At least I know now that we cannot expect quick fixes, although it is very sad to hear since this is a very helpful module. Well hopefully we will have a working version sometime in the future :)