Hey in current version 6.x.2.8 the field for additional css class doesn't output the class. On release 6.x.2.6 and everything works fine

CommentFileSizeAuthor
#5 link-625552.patch3.52 KBjcfiala
#4 link-625552.patch2.24 KBjcfiala

Comments

jcfiala’s picture

jcfiala commented
Assigned: Unassigned » jcfiala

Hmm... that's a problem - we don't want to go losing features. I'm not sure why that's happened.

I need to sit down and go through some of the code and work out which code came from which changes.

I wish I had a priority between 'critical' and 'normal' for this.

konrad_u’s picture

konrad_u commented

I wish I could sit down and figure that out however I still lack drupal coding abilities. For right now we'll use older version, however that feature is really useful so eventually needs to be fixed. PRIORITY=ABNORMAL :)

jcfiala’s picture

jcfiala commented

Alright, I've reproduced the problem - that's good, because it means we don't have a problem with the upgrade somehow.

jcfiala’s picture

jcfiala commented
Status: Needs work » Needs review
StatusFileSize
new link-625552.patch2.24 KB

Okay, I've been working on creating a patch to fix this, and created a simpletest that fixes this.

One problem is that currently you're going to have to go back and edit your nodes - we've been writing some data to the field that I think we shouldn't have been.

jcfiala’s picture

jcfiala commented
StatusFileSize
new link-625552.patch3.52 KB

No, wait - this is the correct patch. Forgot to copy a file.

jcfiala’s picture

jcfiala commented
Status: Needs review » Fixed

Okay, I've fixed this and posted the fix, and you can download the dev version with the fix here: http://ftp.drupal.org/files/projects/link-6.x-2.x-dev.tar.gz

Note that part of the problem is that some data's been saved to your fields which may still be a problem. I'm hoping to have a solution in hand for that by the time we crank out 2.9.

konrad_u’s picture

konrad_u commented

Thanks John.

It was actually weird because I had like 5 nodes newly published on ver.2.8 that didn't output the class -but whenever I switched to older ver.2.6 I didn't have to edit those nodes - the classes appeared automatically.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tsi’s picture

tsi commented
Status: Closed (fixed) » Needs work

Sorry to open this but this is still not working for me even with the latest dev

jcfiala’s picture

jcfiala commented
Status: Needs work » Postponed (maintainer needs more info)

TSI, I think this is a duplicate of #626932: Unsupported Operand Types - Bulk URL Aliases, but I'm not sure. I just posted a fix, could you test by downloading the latest version of the 6.x-2.x dev, and testing that?
This will involve doing a database upgrade, so please back up before the test.

Thanks.

If this doesn't help, then please give me more details about your problem.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

css class supported