Additional CSS Class ommited on output

pazuzu - November 6, 2009 - 18:25
Project:Link
Version:6.x-2.8
Component:Code
Category:bug report
Priority:normal
Assigned:jcfiala
Status:closed
Description

Hey in current version 6.x.2.8 the field for additional css class doesn't output the class. On release 6.x.2.6 and everything works fine

#1

jcfiala - November 6, 2009 - 18:34
Assigned to:Anonymous» jcfiala

Hmm... that's a problem - we don't want to go losing features. I'm not sure why that's happened.

I need to sit down and go through some of the code and work out which code came from which changes.

I wish I had a priority between 'critical' and 'normal' for this.

#2

pazuzu - November 6, 2009 - 19:04

I wish I could sit down and figure that out however I still lack drupal coding abilities. For right now we'll use older version, however that feature is really useful so eventually needs to be fixed. PRIORITY=ABNORMAL :)

#3

jcfiala - November 8, 2009 - 18:10

Alright, I've reproduced the problem - that's good, because it means we don't have a problem with the upgrade somehow.

#4

jcfiala - November 9, 2009 - 00:43
Status:needs work» needs review

Okay, I've been working on creating a patch to fix this, and created a simpletest that fixes this.

One problem is that currently you're going to have to go back and edit your nodes - we've been writing some data to the field that I think we shouldn't have been.

AttachmentSize
link-625552.patch 2.24 KB

#5

jcfiala - November 9, 2009 - 00:46

No, wait - this is the correct patch. Forgot to copy a file.

AttachmentSize
link-625552.patch 3.52 KB

#6

jcfiala - November 9, 2009 - 00:59
Status:needs review» fixed

Okay, I've fixed this and posted the fix, and you can download the dev version with the fix here: http://ftp.drupal.org/files/projects/link-6.x-2.x-dev.tar.gz

Note that part of the problem is that some data's been saved to your fields which may still be a problem. I'm hoping to have a solution in hand for that by the time we crank out 2.9.

#7

pazuzu - November 9, 2009 - 23:48

Thanks John.

It was actually weird because I had like 5 nodes newly published on ver.2.8 that didn't output the class -but whenever I switched to older ver.2.6 I didn't have to edit those nodes - the classes appeared automatically.

#8

System Message - November 23, 2009 - 23:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.