Move vertical tabs integration for Flag into flag.module

Yes, I believe this is at least very similar to the D7-style integration, just obviously without the module_exists() check. I'm working on an Integration handbook page for Vertical tabs for both D6 and D7.

Yeah I think the only change would be this would use $form['#attached']['js'][] = ... instead of drupal_add_js(...).

So even cooler news is we now support the #attached => js => array(...) in the vertical tabs backport. I'm also going to be adding #group property support to fieldsets to show which fieldsets should be tabified by default. So now with this updated patch there is nothing that needs to be changed when you port to Drupal 7! HOORAY!

Minor change in the attached JS key to match the D7 library name.

Oh, and I lied. In the D7 port the actual JS will change a little bit. I'm working to see if I can backport those changes as well.

Worth noting that the flag summary JS was removed as of http://drupal.org/cvs?commit=299738.

Adding tag...

Heh, no worries. I just felt bad because it got to the point where I had to remove it from vertical_tabs.module. :)

+++ flag.module	8 May 2010 20:44:35 -0000
@@ -384,6 +384,13 @@
+          'js' => array(
+            drupal_get_path('module', 'flag') . '/theme/flag-admin.js',
+          ),
+        ),

The only thing I have to add is I highly recommend adding a key of 'vertical-tabs' to the JS file in here. That way in-case another module needs to change the summary JS, they can easily swap it out (very edge case, but you never know).

Powered by Dreditor.

There isn't a standard on it yet. I came across this problem with pathauto needing to override the path.module fieldset summary:

function pathauto_form_alter(&$form, $form_state, $form_id) {
  // Process only node forms.
  if (isset($form['type']) && isset($form['#node']) && $form['type']['#value'] .'_node_form' == $form_id) {
      ...

      // Override path.module's vertical tabs summary.
      $form['path']['#attached']['js']['vertical-tabs'] = drupal_get_path('module', 'pathauto') . '/pathauto.js';

I filed a patch for D7 but it hasn't had much traction and I haven't put much effort to push it either. This problem is going to be worse in D7 because in D6 we only support the #attached from the backport module. In D7 there could easily be more than one JS in a fieldset's #attached. If you have better ideas, I'd love to hear them in the core issue.

FYI #654894: Difficult to override a vertical tabs summary JS is the issue for Drupal core.