Download & Extend

Implement version detection for client's flash player

Project:Image FUpload
Version:6.x-3.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

Per the documentation, this module requires the client to be using Flash 9 or 10. While this covers the majority of users, there are users with older versions of flash. In my case, when I tried the module on an IE client with Flash 6, the upload icon would not appear and no other message was presented to the user.

Adobe provides a toolkit for detecting the client's flash version here:
http://www.adobe.com/products/flashplayer/download/detection_kit/

This is a request to enhance the module to provide additional detection of flash and providing a cleaner message to the user if they don't have a version high enough to work with image_fupload.

Comments and thoughts?

Comments

#1

Can I request that the module fall back gracefully in the case where the user does not have flash to still allow single image upload. Installing this module makes your site unusable if the user does not have flash.

#2

Hi,
Since this feature was a lack and I really needed it, I developed a solution. Please have a look at the attached patch and tell me if it is working fine for you.

AttachmentSize
image_fupload-flash_version_detection-625904-2.patch 17.2 KB

#3

Status:active» needs review

#4

The patch is corrupt (just removals). Please create agaian a patch against head.

#5

My apologies for the previous patch (-_-)", guess I was tired !
Here is a new version, hope this one is working, at least it does add code instead of removing this time ;-)
Do not forget to add the following js from SWFUpload : swfupload.swfobject.js, I did not include it in the patch, just modified the readme.txt to warn user they should include it.
Regards,
Raphael

AttachmentSize
image_fupload-flash_version_detection-625904-2.patch 5.03 KB

#6

Thank you very much! I'll do some testings next week.

#7

This is working for me, except for the fact that it allows people to add more than one image to their node now, whereas before image_fupload was creating a new node for each image. Working on a patch to only allow one value in the noflash version.

#8

I ended up doing this via hook_form_alter:

<?php
function mymodule_form_alter(&$form, &$form_state, $form_id) {
  if (
$form_id == 'image_node_form') {
   
$form['field_image'][0]['#delta'] = 1;   
    unset(
$form['field_image']['field_image_add_more']);   
  }
}
?>
nobody click here