#D7CX

CommentFileSizeAuthor
#6 noderefcreate_d7.zip8.21 KBjackbravo
#5 port_to_d7-626048-5.patch26.08 KBjackbravo

Comments

blavish’s picture

blavish commented

subscribe!

ryan.armstrong’s picture

ryan.armstrong commented

Subscribe!

tesmon’s picture

tesmon commented

Subscribe!

AgaPe’s picture

AgaPe commented

Is there a plan to do this?

jackbravo’s picture

jackbravo commented
Status: Active » Needs review
StatusFileSize
new port_to_d7-626048-5.patch26.08 KB

Hi

I ported this to drupal 7 with help from coder and copying almost all the code from node_reference (references module). Seems to be working.

jackbravo’s picture

jackbravo commented
StatusFileSize
new noderefcreate_d7.zip8.21 KB

Forgot to add the .zip in case anyone wants to just donwload and try.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@jackbravo: good work, looking forward to testing it.

danthewolfe’s picture

danthewolfe commented

This port is working good for me. Thanks!

jackbravo’s picture

jackbravo commented

Here is my github page for this in case anyone is interested: https://github.com/jackbravo/noderefcreate

mitchell’s picture

mitchell commented
Status: Needs review » Reviewed & tested by the community

The patch looks good, except the license file isn't necessary.

@jackbravo: I added you as a maintainer. If you have any questions, you can start with the handbook and project resources, How to be a good maintainer and Node Reference Create Git Instructions, and I'll be on irc a well. Good luck.

bnoice’s picture

bnoice commented

@jackbravo: Looks you're the new maintainer whether you wanted it or not! ;-)

It would be swell to get your version into the normal release channel.

BTW, I'm testing it and it seems to be working great!

jackbravo’s picture

jackbravo commented

Today I stumbled into this issue, I'm recordering it here so I remember to check for this later.

Notice: Undefined variable: node in noderefcreate_autocomplete_validate() (line 131 of /var/aegir/platforms/chia-drupal-0.1/profiles/chia/modules/contrib/noderefcreate/noderefcreate.module).
Notice: Trying to get property of non-object in noderefcreate_autocomplete_validate() (line 131 of /var/aegir/platforms/chia-drupal-0.1/profiles/chia/modules/contrib/noderefcreate/noderefcreate.module).

Hi @opensanta! as @bnoice says, this wasn't expected, but thanks a lot! this will be my first =). I will publish a dev release for d7 as soon as possible.

jackbravo’s picture

jackbravo commented

Hi @opensanta. I created the 7.x-1.x branch and commited the changes to git.drupal.org

Do I have to do anything else to publish the dev branch on the project page? Thanks!

mitchell’s picture

mitchell commented

I checked the repo and everything looks in order. The next step is creating a release for people to be notified of the project's progress and so they can quickly see a description of the package they're downloading.

You'll see at the very bottom of noderefcreate's git instructions there is a section for making releases, and the actual link to create a release is on the project page below the download link where it says 'View all releases'.

The handbook has two pages on contrib projects' release naming conventions and types of releases. Both are pretty long, but well worth the read. I think a usable summary of them could be, if you plan to update the code rapidly, put up a -dev release. If your goal is to stabilize a branch, then make a -beta release of it and prioritize changes that move toward a 'point' release.

Thanks and smooth sailing, jackbravo!

jackbravo’s picture

jackbravo commented

Ok, found the links. Thanks opensanta!

I guess the best way to go is a beta.

ogi’s picture

ogi commented

subscribe

hifalutin’s picture

hifalutin commented

Re the "Undefined variable" error on line 131 -- Just posted this as a separate issue, http://drupal.org/node/1120038

jackbravo’s picture

jackbravo commented
Status: Reviewed & tested by the community » Fixed

Forgot to mark this as fixed.

Status: Fixed » Closed (fixed)
Issue tags: -D7CX

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +D7CX

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.