Not working with Views 6.2.7?
Patroclas - November 7, 2009 - 13:30
| Project: | Views Tabs |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
This plugin appears to be incompatible with Views 6.2.7? My views using this module are not working using tabs to display node content.
#1
I have the same problem, anyone know whats wrong?
#2
This is probably the reason (from Views 2.7 release notes) - but I don't have the ability to find out what the solution may be
#3
Subscribe
#4
I can confirm that the 2.7 update to views broke this module. Since this is a large part of one of the pages on our site I am going to try to patch this today.
#5
Great, a patch would be very welcome.
#6
Posted #628810: Views Tabs broken with changes made to 2.7 in the Views issue queue to get some help on what they changed.
#7
I've got it fixed when you are using fields for the row style, but I still need to work on when you are using node.
Patch will be coming soon.
#8
Welcome the patch. If I could get someone else to verify that this fixes it for them (It works great for me) then I will go ahead and commit it.
#9
#10
+++ views_tabs_plugin_style.inc 10 Nov 2009 22:37:54 -0000@@ -1,13 +1,13 @@
-
+
Some extra white space introduced.
+++ views_tabs_plugin_style.inc 10 Nov 2009 22:37:54 -0000@@ -1,13 +1,13 @@
-
+
Ditto.
+++ views_tabs_plugin_style.inc 10 Nov 2009 22:37:54 -0000@@ -32,43 +32,62 @@ class views_tabs_plugin_style extends vi
+
Ditto.
+++ views_tabs_plugin_style.inc 10 Nov 2009 22:37:54 -0000@@ -32,43 +32,62 @@ class views_tabs_plugin_style extends vi
+ if (!$tabset[$title]) {
+ $tabset[$title] = array(
+ '#type' => 'tabpage',
+ '#content' => $content,
+ '#title' => $title,
+ '#attributes' => array('class' => 'tab-title'),
+ );
All but the first line need two spaces additional indent.
+++ views_tabs_plugin_style.inc 10 Nov 2009 22:37:54 -0000@@ -32,43 +32,62 @@ class views_tabs_plugin_style extends vi
+ return tabs_render($tabset);
We don't actually need to use tabs_render anymore--we can use simple drupal_render().
#11
This patch doesn't seem to fix the problem for me, is this still a work in progress?
#12
Yes, I was waiting for someone else to comment on whether it works for them. Please describe in as much detail as possible what is not working.
#13
I set-up a test with two tabs, the first tab is missing the Title text but does provide a link.
The second tab is not generating anything for the tab, just the body.
The second tab body content is also placed below the first tab content and not hidden.
<div class="view-content"><div id="tabs-tabset" class="drupal-tabs js-hide">
<ul class="tabs clear-block">
<li class="tab-title tabs-tabset-1"><a href="#tabs-tabset-1"><span class="tab"></span></a></li>
</ul>
<div id="tabs-tabset-1" class="tabs-tabset">
<h2 class="drupal-tabs-title js-hide"></h2>
<div class="views-field-body">
<div class="field-content">
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam eleifend est non nulla lacinia accumsan. Nulla facilisi. Suspendisse ac posuere augue. Sed ante risus, lobortis viverra dictum ac, feugiat sed est. Quisque in diam tincidunt nibh fermentum tristique. Nullam pulvinar est quis libero dictum mollis. Vivamus massa mauris, varius a porta eu, ultricies a elit. Proin mauris nunc, dignissim a vestibulum in, pharetra ac turpis. Integer placerat mattis magna ac fermentum. Maecenas aliquam lorem vel elit varius cursus.</p>
</div>
</div>
<div class="views-field-body">
<div class="field-content">
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam eleifend est non nulla lacinia accumsan. Nulla facilisi. Suspendisse ac posuere augue. Sed ante risus, lobortis viverra dictum ac, feugiat sed est. Quisque in diam tincidunt nibh fermentum tristique. Nullam pulvinar est quis libero dictum mollis. Vivamus massa mauris, varius a porta eu, ultricies a elit. Proin mauris nunc, dignissim a vestibulum in, pharetra ac turpis. Integer placerat mattis magna ac fermentum. Maecenas aliquam lorem vel elit varius cursus.</p>
</div>
</div>
</div>
</div>
</div>
#14
Hate to say this, but that doesn't help very much. Please export your view and post as an attachment so I can understand how you are making the view or possibly a link to the page this is happening on.
#15
Actually I got it to work... I set the view "Grouping field" and it works fine now.
http://precisionmedical.venus.klunkmillan.net/hospitals/test-tab-page
#16
Patch rerolled.
Any reasons why this should not be committed?
#17
subscribing
#18
subscribing