problem after changes in the general tab => "Discover all node properties for selection" is incompatible to some modules
carolaun - November 7, 2009 - 15:22
| Project: | ThemeKey |
| Version: | 6.x-1.2-beta4 |
| Component: | Installation / Configuration |
| Category: | bug report |
| Priority: | critical |
| Assigned: | mkalkbrenner |
| Status: | closed |
Jump to:
Description
After I tried the second selection possibility in the general tab, I am no mor able to get access to the general tab again. (Sorry not to be more precise, though I am no more able to have a second look)
The only info I still can see is a big red warning on a conflict with an other module. After disabeling this module I get the information, that the general tab cannot be found anymore.
Is there any possibility to get the original selection back? I tried to reinstall the module but without any success.
Thanks for your help!
| Attachment | Size |
|---|---|
| themekey-general_110709.JPG | 93.53 KB |
#1
Already the second report of this issue . See #620352: Setting page is not found.
#2
Since I took over responsibility for ThemeKey I didn't like the way "Discover all node properties for selection" works. Especially this piece of code seems dangerous and I'm convinced that it causes the devision by zero seen in the screenshot:
<?php$node_types = node_get_types();
//
foreach ($node_types as $node_type) {
$form_state = array();
$form_id = $node_type->type .'_node_form';
$node = array('uid' => 0, 'name' => '-', 'type' => $node_type->type, 'language' => 'en');
//
$form = drupal_retrieve_form($form_id, $form_state, $node);
$form['#post'] = array();
drupal_prepare_form($form_id, $form, $form_state);
$form = form_builder($form_id, $form, $form_state);
$node = node_form_submit_build_node($form, $form_state);
//
_themekey_node_discover_properties($node, $properties);
$properties = array_diff($properties, $ignore);
}
?>
Maybe it's the best solution to completely remove this feature from TemeKey.
This also means to never "Add support for CCK fields (esp. numeric fields) by making the node discovery algorithm smarter" that way.
#3
Great you took over responsibility!
Thanks so much!
#4
"Discover all node properties for selection" will be removed for 6.x-1.2beta5 ...
#5
#6
Automatically closed -- issue fixed for 2 weeks with no activity.