Closed (fixed)
Project:
Hierarchical Select
Version:
6.x-3.x-dev
Component:
Code - Taxonomy Views
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
7 Nov 2009 at 15:37 UTC
Updated:
17 Oct 2010 at 21:30 UTC
Jump to comment: Most recent
Comments
Comment #1
wim leersOdd. Seems that Views is not attaching Drupal behaviors? Moving to the Views issue queue to get feedback.
Comment #2
merlinofchaos commentedIf hierarchical select uses the 'settings' javascript, then it is difficult to transmit these settings back to the page during ajax operations. (Note that the ajax system in Drupal 7 has more or less aleviated this, but in D6 this is still a problem).
Views *does* call behaviors in its ajax operations.
Comment #3
wim leersI see. HS indeed uses Drupal.settings. Thanks Merlin!
Comment #4
wim leersThis will cost a fair amount of time and frustrated debugging sessions. Drupal's AHAH/AJAX support is too immature to accommodate for this properly.
I'll welcome your patches but I won't figure out a work-around in my free time.
Comment #5
wim leersComment #6
zeezhao commentedWim - this sounds related to the issue I posted here: http://drupal.org/node/734178#comment-3212202
I am willing to sponsor a fix if it can solve my issue in the link. Please let me know. Thanks.
Comment #7
dgastudio commented+1
Comment #8
wim leersReproduced.
zeezhao is sponsoring the fix.
Comment #9
wim leersEventually, I found an acceptable work-around! Fixed.
http://drupal.org/cvs?commit=412572
Comment #10
VTM commentedHere is what I get after installing the 3.x-dev:
I use 2 taxonomy terms (each has it's library) for search using Views.
After paging, I see that the bug is fixed for the second (last) term.
But for the first one, the message "You don't have Javascript enabled ..." is still there.
switching the order of these two terms - still the second (last) term is OK, the first one not.
The above description happens after a refresh was made to a page.
I use level labels.
I selected "all" in both terms, without clicking the "search" button. The message did not appear after paging
tried to do the same while both level lables disabled - the message appeared after paging.
Hope this info help.
To add more info:
I use module "views display tabs".
If I enable the Ajax option in the view then I see the above JS message when paging.
If I disable it - no problems with the pager
Comment #11
Anonymous (not verified) commentedThis patch has the consequence of adding Drupal.HierarchicalSelect.ajaxViewPagerSettingsUpdate as a callback to ALL Ajax Views requests, even for Views which don't use a hierarchical select widget. In these cases, the HS widget's scripts haven't been loaded (because they're not needed), so all these views break as a result because (Safari)
TypeError: Result of expression 'Drupal.HierarchicalSelect' [undefined] is not an object.I've opened an issue #911486: ajaxViewPagerSettingsUpdate callback added to all ajax Views callbacks even when HS widget isn't used..Comment #12
opteronmx commented#11 I had a similar issue with 6.x-3.5, what I did was just add a try catch block in function Drupal.HierarchicalSelect.ajaxViewPagerSettingsUpdate changing this:
to this:
Well, maybe this is just a fast workaround, but by doing this I avoid JS from crashing, and as I'm not using hierarchical select widget on my exposed field, it doesn't matter that: "Drupal.settings.HierarchicalSelect is undefined" [Error thrown in console].
Regards
Comment #13
jvieille commentedI seem to have a related issue:
My pagers don't work anymore for any view. It shows up correctly but is totally inactive. The Java console reports this error:
Uncaught TypeError: Cannot read property 'ajaxViewPagerSettingsUpdate' of undefinedIf I disable Ajax, it works.
If I disable Hierarchical Select, it works (though HS is not involved at all)
Comment #14
mikeytown2 commentedWas getting
Drupal.HierarchicalSelect is undefinedwith 3.5; latest dev fixes the issue. #911486: ajaxViewPagerSettingsUpdate callback added to all ajax Views callbacks even when HS widget isn't used.Comment #15
wim leersmikeytown2's comment implies that I should issue a new release. So that's what I'm doing right away :)
Comment #16
wim leersDone: HS 3.6 — http://drupal.org/node/930560.