Posted by icylace on November 7, 2009 at 4:24pm
Jump to:
| Project: | Services |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
This patch builds on top of #616490: Services API misuses hash/number (#) symbols by taking out hashes that were still in the _services_keyauth_alter_methods() function in services_keyauth.inc. This will fix session ID handling.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| services_d6_hash_update.patch | 1.56 KB | Ignored: Check issue status. | None | None |
Comments
#1
I'm curious what session ID handling problem this fixes? I'm not against the patch I'm just curious.
#2
When I tried using the JSON Server module I wasn't able to use my services because the module was looking for hashed properties that no longer existed given the latest Services module development code. After modifying the JSON Server code to look for hashless preperties (planning to submt a patch soon to that project) it wasn't finding the session ID argument because the code defining it still included hashes. My patch removes those hashes to fix the problem.
#3
Also, when testing my services on the Services admin pages the sessid parameter was not showing properly. This prompted me to do a dump of the service method data structure to discover that the sessid argument had hashes in its definition. Then it was a matter of finding out where it was being originally defined and removing the hashes.
#4
This should be committed as soon as possible. The change is necessary, and the patch applies cleanly.
A CVS-savy person might want to do that as I might just as well botch the trunk as succeed in committing the patch.
Cheers,
Hugo
#5
Committed thanks to free wifi at Portland International Airport. Thanks!