To be used on g.d.o, it would be helpful if this module merged group membership as well as group subscriptions.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 626436-merge-og-6.patch | 2.09 KB | coltrane |
| #4 | 626436-merge-og-4.patch | 1.58 KB | coltrane |
To be used on g.d.o, it would be helpful if this module merged group membership as well as group subscriptions.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 626436-merge-og-6.patch | 2.09 KB | coltrane |
| #4 | 626436-merge-og-4.patch | 1.58 KB | coltrane |
Comments
Comment #1
gregglesIf those two things don't include it, then this should also include group admin status. Probably in a way where if a user has two memberships in a group and one of those memberships is as an admin then that should be the one that is kept.
Comment #2
gregglesAre subscriptions really different or is that really about #640942: Merge notifications and messaging settings for a user?
Comment #3
gregglesComment #4
coltranePatch implements usermerge hooks on behalf of og for merging membership (and admin). It only updates the og_uid table, which is all I believe og uses.
Comment #5
coltraneHmmn, the straight update could create problems. It needs to more intelligently merge.
Comment #6
coltraneWe find the groups kept-user is not a member of and update them then we set blocked-user to inactive on any his or her's remaining groups.
Comment #7
gregglesThis patch looks good to me. It handles the merge of users. It doesn't properly grant admin rights to "user to keep" if "user to delete" was an admin and "user to keep" isn't...but that seems like a small feature that may not be worth adding.
Comment #8
gregglesLeaving as "needs work" for that last point about elevating the "user to keep" to admin if the "user to delete" had admin rights.
Comment #9
gregglesI forgot to say the first part of that message:
This has been applied - http://drupal.org/cvs?commit=339220 - thanks, Ben!
Comment #11
fool2 commentedI see the commit message in this thread, I followed the commit link and see D7 code, but I cannot find this code in 2.x or 2.x dev. Usermerge does not currently merge group membership (unless I'm missing something), and there is no mention in the code. Any idea why this code is lost?
Comment #12
gregglesThis was committed to 6.x, but not ported to 7.x in [1203596] the commit that removes it is https://git.drupalcode.org/project/usermerge/commit/d84e1d08f8b96d671639...
So this is basically back to "Active" status as a feature request for 7.x.
Comment #13
fool2 commentedGreat, I may have a whack at it or get my company to sponsor the work. Thanks for the decade-later update!
Comment #14
fool2 commentedSo, a one line edit at Line 388 on usermerge.usermerge.inc:
Will make group membership merge. I don't think this merges group roles, however, but as we are not using them currently it seems to work for us.
I'm worried there are other issues with doing this, but it's a starting point. Is there a way to pluck this field out of the "other" array and put it elsewhere?