Uninstall code creates infinite loop

DamienMcKenna - November 8, 2009 - 04:28
Project:Taxonomy Super Select
Version:5.x-1.5-1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

The taxonomy_super_select_uninstall() function uses db_result, which in D5 resets the database counter on each call, thus creating an infinite loop. A better way would be the following:

<?php
 
while ($vocab = db_fetch_object($result)) {
   
variable_del('taxonomy_super_select_vid_'. $vocab->vid);
  }
?>

#1

DamienMcKenna - November 8, 2009 - 04:29
Status:active» needs review

Here's a quick patch that changes the uninstall code to the code listed above.

AttachmentSize
taxonomy_super_select-n626596.patch 2.17 KB
 
 

Drupal is a registered trademark of Dries Buytaert.