xmlrpc_server patch for d7

ilo - November 8, 2009 - 11:09
Project:Services
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:ilo
Status:active
Description

Hi

I just assigned for myself as I had already started to look at it.

Probably for better understanding and patch reviewing, adding a comment paragraph to functions that don't have any would help, at least for hook functions. Do I include these comments in the patch or not?.. should the patch wait for the #616490: Services API misuses hash/number (#) symbols issue to be fixed? I know heyrocker is rolling a patch for d7 with that.

My idea for the patch is to simply make it working (as is) but detail detected errors in this issue.

current issue list for xmlrpc_server module:

- xmlrpc_server_xmlrpc() function signature is wrong or not documented.
- xmlrpc_server_call_wrapper() function signature is wrong or not documented.
- hook_server_error() function signature is wrong or not documented.
- hook_server_error() function is ignoring code and exception arguments sent by services_error.
- hook_server_error() regex doesn't work, and returned error code is 1 in most cases.
- hashes are being used for server definition (see #616490: Services API misuses hash/number (#) symbols)

 
 

Drupal is a registered trademark of Dries Buytaert.