Flags can't be edited

asb - November 8, 2009 - 15:30
Project:Flag
Version:6.x-1.1
Component:Flag core
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hi,

I just installed the 'flags' module on a pretty freshly set up site; As ususal, I downloaded the module, enabled it, and ran update.php.

At the administration interface (./admin/build/flags) I'm seeing the preconfigured "bookmarks" flag, and I can add new flags (like "revisal"). However, I can't edit the existing flags once the've been created: At the administration screen, there are no links for "Operations". This is definitely an unexpected behaviour; usually, here are liks to edit and delete the configured flags.

I'm currently working as user #1, so this can't be related to access permissions; however, I tried this with a different role ("sysop") with full permissions to administrate flags, and there are also no "Operations" links. However, when accessing the guessed paths (e.g. ./admin/build/flags/edit/bookmarks or ./admin/build/flags/edit/revisal), the edit screen appears.

Also, for newly created flags - like the mentioned "revisal" - no menu items appear; I checked at ./admin/build/menu if the menu items were created but disabled, but they're simply not there. So something is very profoundly going wrong on the new site. This is quite irritating since I'm using the 'flags' module on several other D5 and D6 sites without similar problems.

The only difference to those sites is that I'm running the 'memcache' module on the problematic site. Is anybody else experiencing similar problems when using 'flags' and 'memcache modules together? Are there any known incompatibilities, and if so, are they caused by 'flags' or 'memcache' module?

Thanks & greetings, -asb

#1

quicksketch - November 8, 2009 - 22:57
Category:bug report» support request

This sounds like a problem with this particular site. Like you say, Flag runs perfectly fine on other sites. I run memcache on several sites that also run Flag, so I don't think it's a direct conflict between the two modules.

Also, for newly created flags - like the mentioned "revisal" - no menu items appear; I checked at ./admin/build/menu if the menu items were created but disabled, but they're simply not there.

You should note that Flag never makes visible menu entries for each individual flag. The edit/delete pages for individual flags are registered as paths but not ever as menu items, so they don't show up in admin/build/menu at all.

If I had to take a guess, I'd guess that your theme is interfering somehow. Perhaps it's overridding theme_flag_admin_page() and causing the links to not appear. Try switching your admin theme to Garland and see if the links appear there.

#2

asb - November 9, 2009 - 00:44

Hi quicksketch,

> If I had to take a guess, I'd guess that your theme is interfering somehow. [...]
> Try switching your admin theme to Garland and see if the links appear there.

Good guess, indeed very good guess, the links show up in Garland.

> Perhaps it's overridding theme_flag_admin_page() and causing the links to not appear.

??

cat template.php | grep theme_flag_admin_page gives me nothing for my theme (a simple derivate of 'Marinelli'). Could this be simple CSS (something trivial setting 'foo' to display: none;?

> You should note that Flag never makes visible menu entries for each individual flag.
> The edit/delete pages for individual flags are registered as paths but not ever as menu
> items, so they don't show up in admin/build/menu at all.

Sorry, this was unclear (written unclear, and unclear to me). I was referring to the "user" menu entries like "My bookmarks", located e.g. at ./bookmarks, not to the edit/delete links. However, now you got me confused; I checked this on another D6 site, and there not even the default "Bookmarks" show up - I assumed that every flag would appear by itself with "My {flag-name}" links in the menu (default: 'Navigation'), and I was pretty sure that this was default behaviour on my D5 sites. Hmm, I seem to drink too much, damn ;-/

Thanks & greetings, -asb

#3

quicksketch - November 9, 2009 - 20:57

In your theme the function would be called [theme_name]_flag_admin_page or phptemplate_flag_admin_page. You might also look for [theme_name]_links or phptemplate_links, as that's a much more likely thing to override and could also cause links to mysteriously disappear.

Also regarding "Automatic" menu links: These used to be automatically created for you in beta versions of Flag, but were removed in the 1.0 version. The only menu link that comes with Flag is "My bookmarks", but this is only shown if you have a "bookmarks" flag and have not modified the Views that Flag ships with.

#4

asb - November 9, 2009 - 21:16
Status:active» closed

No, there are no such functions in my template.php. But in the stylesheet, indeed several elements were set to display: none;. I fixed this and got the edit/delete links back.

Thank you! -asb

 
 

Drupal is a registered trademark of Dries Buytaert.