Merge nodewords - vertical tabs into main module

hass - November 8, 2009 - 19:11
Project:Nodewords
Version:6.x-3.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

If the code is not inside the main module I can keep the submodule disabled and configure nodewords fieldsets in the content types to go into vertical tabs. Nobody expects an extra module for this and it's circumventable by default.

I have already done this in past on my dev box.

#1

kiamlaluno - November 9, 2009 - 10:03

I kept the code in a separate module because I thought there were incompatibilities between the weight of the modules. As Vertical tabs as a higher weight, I think there should not be really incompatibilities.

I can keep the submodule disabled and configure nodewords fieldsets in the content types to go into vertical tabs.

The settings that Vertical tabs add to the content type form handle only the node edit form, while the code I added allow to integrate Vertical tabs in Nodewords forms (which means forms created by Nodewords, not forms where Nodewords add form fields).

#2

kiamlaluno - November 9, 2009 - 10:04
Category:bug report» task

#3

kiamlaluno - November 9, 2009 - 10:13
Status:active» fixed

The code has been merged.

Thanks for your report.

#4

kiamlaluno - November 9, 2009 - 10:19

I will change the code in the branch 6.x-1 later.

#5

hass - November 9, 2009 - 10:22

Great, I will take a look to 3.x - I wasn't aware that this wasn't for the node edit forms... I have read about possible incompatibilities with vertical tabs on node forms and thought this is made for this reason... how close is 3.x for production? I really need the token stuff within the next ~2 weeks in a new production site... :-)

#6

kiamlaluno - November 9, 2009 - 12:04

For the support of third-party modules in Vertical tabs, see #500044: Extend the support to different modules / form pages.

Nodewords 6.x-3 is under a complete rewritten. The code is going to be change to implement some classes that will allow to reduce the duplication of code in the code for handling the meta tags, and allow administration users to create custom meta tags from the user interface.

#7

System Message - November 23, 2009 - 12:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.