Unnecessary prefix on field 'add more' $form element

Posted by yched on November 9, 2009 at 12:57am

Issue Summary

Pointed by sun while discussing #626354: Remove #process pattern from number field:
We don't need to prefix the key of the 'add more' button in the $form structure - basically:

-      $form_element[$field_name . '_add_more'] = array(
+      $form_element['add_more'] = array(

Unneeded cruft, the #name property already contains all the info needed to differentiate between the several buttons in the page.

Attachment	Size	Status	Test result	Operations
field_rename_add_more.patch	1.65 KB	Idle	Passed: 14701 passes, 0 fails, 0 exceptions	View details

Posted by yched on November 9, 2009 at 3:49pm

Component:

simpletest.module

» field system

Doh, FF preselected a wrong component for me...

Posted by sun on November 9, 2009 at 4:30pm

Status:

needs review

» reviewed & tested by the community

No, that's Dreditor :) It stores the last selected component for each project. ;)

Can you roll patches with diff -up, please, so we can see the context of the changes? :)

Posted by yched on November 9, 2009 at 4:33pm

ach - I new I started seeing this at some point, but did not connect with dreditor.

diff -up: I know, sorry, Eclipse patches here :-(

Posted by Dries on November 9, 2009 at 6:23pm

Status:

reviewed & tested by the community

» fixed

Committed to CVS HEAD. Thanks!

Posted by System Message on November 23, 2009 at 6:30pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.