auction multiple bug fix

New patch

auction_help
Added a description for auction when creating content.

auction_ec_settings
Instead of auction_settings. (thanks neclimdul)

auction_productapi op = validate
Fixed empty expires date. (thanks neclimdul)
http://drupal.org/node/62371
Stopped trying to change the value. Just validate it and set error.
Also, handle strtotime return of -1 or 0 depending on php version.
So if we get past validation to the insert or update, the strtotime conversion of expiry occurs then.

auction_checkout_page
Fixed bug of query with empty IN list
http://drupal.org/node/62369
Generally ightened this up, took out cruft, 2 less queries. All it does now is add the cart items (if not already) and sends user to the checkout. Ie. it leaves the checkout logic to the checkout - after all the user might have non-auction items in the cart, so we don't want auction.module to stop it.

auction_item_paid_for
Another query that occasionally runs a query with an empty IN list. Just rejigged the logic a bit.

auction_bid_current
auction_get_current_bid and auction_bid_history_count were doing almost the same thing and being called from the same query. The result is auction_bid_current, which is the current bid plus a count of bids.

form theming
I tightened up the form code a lot. If you look at theme_product_auction_form(), you see that it has no logic in it, so it is much easier to retheme. All the non-form data is now stored in $form['theme'] which makes things a no-brainer.

The other major change is in theme_product_auction_view() which previously did not cover a number of logical scenarios. Now a quick read will reveal the logic behind this function with a message for all occasions.

Also, the messages are much more generic and should apply to most situations. They do not refer to "items" which would be a pain if your were selling a service for example.

...and
I think this bug is also fixed...
http://drupal.org/node/46087

So that's a starter.

.s