attachment module support

Your forgot to provide a new patch that fixes the typo.

No, the problem is that I'm flat out like a lizard drinking.

I want to spend a good solid day on inline really soon. I want to get some of Bert's new syntax into the 4.7 branch of inline before too many people install it for 4.7. And there are several other patches that look good but need further analysis. And of course there's work to merge all these patches together.

I'll try to stay up late tonight or tomorrow and get the "ready" patches all committed.

Sun, thank you for your file but there is still something wrong for me. I always got NOT FOUND: when I use [inline:my_file.xx], thought I know it works with the current inline cvs ! I may miss something ? Any idea ? regards, eric.

PS : did I say I'm using it with a 471

thanks for all the good work Sun. However, things are getting a bit messy. I tried to patch the file, but got some problems. When I try to use the file ID, I get database errors, when I use the file name, the file name still shows up on the page (in addition to the given name). Maybe I did the patching wrongly? Perhaps you could provid with the latest version, everything already patched?

thanks in advance,
boris

Patch fails.

Also: This patch tries to do too many things in one (which makes it very hard to maintain and review).

Lets try to solve the issues one at a time. Leave this issue for integration with attachement.module, move the preview issues etc to to other threads.

Posts seem to indicate people are having problems with patch #5, 6 and 7. I just want to fix the problem that titles are not displaying as they should with Drupal 4.7.2. Instead of seeing title, file name is displayed.

When I specify a title like [file:myfile.pdf=mytitle], inline.module ignores title and provides a link like

<a href="myfile.pdf">myfile.pdf</a>

it should be

<a href="myfile.pdf">mytitle</a>

Which patch should I apply to fix this? Patch 0?

Also, what is the difference between [file:myfile.pdf=mytitle] and [attachment:myfile.pdf=mytitle]? They seem to function the same?

Thanks.

I just tried the "inline_7.module" patched module, and it does seem to fix the "title not shown" bug.

Spotted a little typo in the inline_filter_tips() text: "will be replaced by... file1.pdf.png" should be "file1.pdf".

I like the idea of the "{current_theme}/mime" folder containing little icons showing the file tye... must give it a try!

Tried it with a couple of icons. Looks great! Well done!

The only thing that I'm not so keen on is that when you use something like "[file:myfile.pdf=My File]", you get this:

[icon] My File (11.66 KB)
myfile.pdf

I would prefer just this:

[icon] My File (11.66 KB)

The file name is included in the pop-up "title" anyway, and the whole reason why I would want to use my own "title" is to hide what might be a nasty long filename.

Anyway, a quick bit off CSS soon fixed that:

.inline dd { display: none; }

It might be worth including a tip about this in the README.txt (and supplying a few demo icons) when this module is next released.

On the subject of icons - wouldn't it make more sense to have the "mime" folder as a sub-directory of this module rather than in the theme?

Not complaining though... I think this patch is a *great* improvement.

Bit. off topic but i have little idea. For simpler use inline module with TinyMCE editor i have use in my template.php this function:

<?php
/**
* Theme the attachments list. (from upload.module -> themeupload_form_current())
*/
function phptemplate_upload_form_current(&$form) {
$counter = 1;

$mime_type_array['image'] = array('image/jpeg','image/pjpeg','image/gif','image/png');

$header = array(t('Delete'), t('List'), t('Description'), t('Size'), t('Insert inline picture'));

foreach (element_children($form) as $key) {
// check if is image
if (in_array($form[$key]['filemime']['#value'],$mime_type_array['image'])) {
$typ_image = true;
}
else {
$typ_image = false;
}
$row = array();
$row[] = form_render($form[$key]['remove']);
$row[] = form_render($form[$key]['list']);
$row[] = form_render($form[$key]['description']);
$row[] = form_render($form[$key]['size']);
// insert inline tag into textarea
if ($typ_image) {
$row[] = "insert image code";
}
else {
$row[] = '';
}
$rows[] = $row;

$counter++;
}
$output = theme('table', $header, $rows);
$output .= form_render($form);
return $output;
}

Maybe is there better way integrate this funcionality into inline.module?

Ups, sorry for this... Maybe someone can delete previous post?

/**
 * Theme the attachments list.
 */
function phptemplate_upload_form_current(&$form) {
  $counter = 1;

  $mime_type_array['image'] = array('image/jpeg','image/pjpeg','image/gif','image/png');
  
  $header = array(t('Delete'), t('List'), t('Description'), t('Size'), t('Inline picture'));

  foreach (element_children($form) as $key) {
    // is image?
    if (in_array($form[$key]['filemime']['#value'],$mime_type_array['image'])) {
      $typ_image = true;
    }
    else {
      $typ_image = false;
    }
    $row = array();
    $row[] = form_render($form[$key]['remove']);
    $row[] = form_render($form[$key]['list']);
    $row[] = form_render($form[$key]['description']);
    $row[] = form_render($form[$key]['size']);
    // if is image create link for insertting inline code
    if ($typ_image) {
      $row[] = "<a href=\"javascript:tinyMCE.execInstanceCommand('mce_editor_0','mceInsertContent',true,'[inline:".$counter."]')\">".t('insert code for image')."</a>";
    }
    else {
      $row[] = '';
    }
    $rows[] = $row;
    
    $counter++;
  }
  $output = theme('table', $header, $rows);
  $output .= form_render($form);
  return $output;
}

This code simple add new column to attachements table with link for insert inline image code into textarea.

This looks very good. Let us dive into these issues one a time and get them reviewed and patched. (one a time).

I realise this is very suboptimal, but unfortunately another route does not really work right now. I mean: nearly all of the issues in here are from your hand, just updating the issue with latest heads :)

I would love to see the issues solved.

@Richard: I would like to discuss CVS access so that I can get the issues solved. There are a load of issues solved but waiting commits, for example: I fixed the previews.

Bèr