Incorrect function for getting vocabulary

nicholasThompson - November 9, 2009 - 12:59
Project:Apache Solr Search Integration
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:claudiu.cristea
Status:needs work
Description

This is a two part patch...

1) There is a fix for the use of a Drupal 6 function (taxonomy_vocabulary_load) where it should be taxonomy_get_vocabulary for Drupal 5.

2) To get the system working with Multisite again, I believe we need to add some facets to the the response... We at least need to make sure the URL's returned are absolute otherwise the multisite URL's end up referring to the external site on internal URL's.

AttachmentSize
apachesolr.multisite-vocab.patch1.79 KB

#1

nicholasThompson - November 10, 2009 - 11:35

Ok - new patch - this one actually WORKS.

It fixes the broken vocab function as before.

Multisite now works. There is an optional facet block + a configuration setting (in admin/settings/apachesolr, under Advanced Settings). This configuration allows you to specify "friendly" names for the sites (rather than the site Protocol + URL being used).

I'm going to roll this out onto a live site today if you need to see a demo of it.

#2

nicholasThompson - November 10, 2009 - 11:35

Crap - forgot the patch...

AttachmentSize
apachesolr.multisite-vocab.patch 6.28 KB

#3

nicholasThompson - November 12, 2009 - 12:15

#4

claudiu.cristea - November 12, 2009 - 12:16
Title:Incorrect function for getting vocabulary + Multisite implementation fix» Incorrect function for getting vocabulary
Assigned to:Anonymous» claudiu.cristea
Status:needs review» needs work

Let's split the issue. In fact there are 2 different issues here. I'll make this only the vocabulary one. Please open another one for the multisite issue.

Thank you.

#5

robertDouglass - November 12, 2009 - 12:29

Agree with splitting the issue. We'll want to forward port this to the 6.x branches as well.

#6

robertDouglass - November 20, 2009 - 14:11

Doesn't look like this actually affects 6.x branches? Please confirm.

#7

claudiu.cristea - November 20, 2009 - 15:45

Didn't have time to look into, but it seems an incomplete backport from 6.x-1.x. It seems that I forgot inside a D6 taxonomy function. While I didn't test ApacheSolr with taxonomy in my 5.x-2.x production site, this error didn't popup.

Yes. It's a "D5 only" issue. If I will discover that it isn't, I will ping you.

 
 

Drupal is a registered trademark of Dries Buytaert.