Download & Extend
Apache Solr Search Integration » Issues

Incorrect function for getting vocabulary

Posted by nicholasThompson on November 9, 2009 at 12:59pm
Project:Apache Solr Search Integration
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:claudiu.cristea
Status:closed (fixed)

Issue Summary

This is a two part patch...

1) There is a fix for the use of a Drupal 6 function (taxonomy_vocabulary_load) where it should be taxonomy_get_vocabulary for Drupal 5.

2) To get the system working with Multisite again, I believe we need to add some facets to the the response... We at least need to make sure the URL's returned are absolute otherwise the multisite URL's end up referring to the external site on internal URL's.

AttachmentSizeStatusTest resultOperations
apachesolr.multisite-vocab.patch1.79 KBIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by nicholasThompson on November 10, 2009 at 11:35am

Ok - new patch - this one actually WORKS.

It fixes the broken vocab function as before.

Multisite now works. There is an optional facet block + a configuration setting (in admin/settings/apachesolr, under Advanced Settings). This configuration allows you to specify "friendly" names for the sites (rather than the site Protocol + URL being used).

I'm going to roll this out onto a live site today if you need to see a demo of it.

#2

Posted by nicholasThompson on November 10, 2009 at 11:35am

Crap - forgot the patch...

AttachmentSizeStatusTest resultOperations
apachesolr.multisite-vocab.patch6.28 KBIgnored: Check issue status.NoneNone

#3

Posted by nicholasThompson on November 12, 2009 at 12:15pm

Fyi - it's live here:
http://www.pponline.co.uk/search/apachesolr_search/boxing

#4

Posted by claudiu.cristea on November 12, 2009 at 12:16pm
Title:Incorrect function for getting vocabulary + Multisite implementation fix» Incorrect function for getting vocabulary
Assigned to:Anonymous» claudiu.cristea
Status:needs review» needs work

Let's split the issue. In fact there are 2 different issues here. I'll make this only the vocabulary one. Please open another one for the multisite issue.

Thank you.

#5

Posted by robertDouglass on November 12, 2009 at 12:29pm

Agree with splitting the issue. We'll want to forward port this to the 6.x branches as well.

#6

Posted by robertDouglass on November 20, 2009 at 2:11pm

Doesn't look like this actually affects 6.x branches? Please confirm.

#7

Posted by claudiu.cristea on November 20, 2009 at 3:45pm

Didn't have time to look into, but it seems an incomplete backport from 6.x-1.x. It seems that I forgot inside a D6 taxonomy function. While I didn't test ApacheSolr with taxonomy in my 5.x-2.x production site, this error didn't popup.

Yes. It's a "D5 only" issue. If I will discover that it isn't, I will ping you.

#8

Posted by nicholasThompson on December 8, 2009 at 5:00pm

Vocab only patch

AttachmentSizeStatusTest resultOperations
apachsolr-vocab.patch919 bytesIgnored: Check issue status.NoneNone

#9

Posted by nicholasThompson on December 8, 2009 at 5:02pm
Status:needs work» needs review

Setting status...

#10

Posted by jaydub on December 18, 2009 at 4:38pm
Status:needs review» reviewed & tested by the community

I ran into this problem as well. The patch to swap the functions works as intended and the taxonomy facet blocks work fine.

#11

Posted by robertDouglass on December 19, 2009 at 10:32am
Status:reviewed & tested by the community» fixed

#627606 by nicholasThompson | jaydub: Fixed Incorrect function for getting vocabulary.

#12

Posted by System Message on January 2, 2010 at 10:40am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.