CVS edit link for jansverre

Since I startet working with and using Drupal 2 years ago, I've used a lot of different modules and themes downloaded from drupal.org. Since my first drupal-site, i've "come a long way", and now have my own business in which setting up drupalsites for customers is a procentage.

After downloading and using Artisteer I've been able to create themes for Drupal without being a programmer. The themes made with Artisteer (http://www.artisteer.com/) works well in all the major browsers (FF, Opera, Chrome and IE) and I belive they meets the standards for accessibility and safety.

I've now come to a point where I would like to contribute back to the community, as a form of "thank you", but also because I think I can provide nice looking themes that can be of use all around the world.

My first theme for free download can be seen here: www.reboli.dk/demo/eastern01
It has 20 regions, support for logo, sitename, site slogan, shortcut icon, but not a missin statement.

Photos use in the theme is owned by me, and I will happily contribute them.

Regards
Jan Sverre Reboli Paulsen

CommentFileSizeAuthor
#3 eastern01.zip875.85 KBjansverre
#1 eastern01.zip882.41 KBjansverre

Comments

jansverre’s picture

jansverre commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new eastern01.zip882.41 KB
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

See the Drupal coding standards to understand how a module code should be written. In particular, see the part about the namespace respect.

The file LICENSE.txt needs to be removed; Drupal.org CVS doesn't allow to commit that file.

The JavaScript file is not using any of the functions made available from jQuery.

jansverre’s picture

jansverre commented
Status: Needs work » Needs review
StatusFileSize
new eastern01.zip875.85 KB

I'm a bit unsure about what you mean.
I have now removed "license.txt" and changed the namespace-issue. Please let me know if there is anything else.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work 
if (get_drupal_version() == 5) {
  require_once("drupal5_methods.php");
}
else {
  require_once("drupal6_methods.php");
}

If the theme is for Drupal 6, then that code is not necessary, as it is not necessary to have a file for Drupal 5, and one for Drupal 6.

My previous points about the namespace, and the JavaScript code not using jQuery code are still valid.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.