file_save fails for remote streams on filesize()

No, I've implemented stream_stat(), but it still fails. Let me try using stat() instead of filesize().

Hmm.. That fails too. Perhaps I'm implementing stream_stat incorrectly?

  /**
   * Support for fstat().
   *
   * @return
   *   An array with file status, or FALSE in case of an error - see fstat()
   *   for a description of this array.
   */
  public function stream_stat() {
    return array(
      'dev' => 0,
      'ino' => 0,
      'mode' => 0,
      'nlink' => 0,
      'uid' => 0,
      'gid' => 0,
      'rdev' => 0,
      'size' => 1000,
      'atime' => 0,
      'mtime' => 0,
      'ctime' => 0,
      'blksize' => 0,
      'blocks' => 0,
    );
  }

(I just have a fake value for size currently, obviously.)

And my stat() implementation, for the record:

/**
 * Save a file object to the database.
 *
 * If the $file->fid is not set a new record will be added. Re-saving an
 * existing file will not change its status.
 *
 * @param $file
 *   A file object returned by file_load().
 * @return
 *   The updated file object.
 *
 * @see hook_file_insert()
 * @see hook_file_update()
 */
function file_save(stdClass $file) {
  $file->timestamp = REQUEST_TIME;
  $stat = stat($file->uri);
  $file->filesize = $stat['size'];

  if (empty($file->fid)) {
    drupal_write_record('file', $file);
    // Inform modules about the newly added file.
    module_invoke_all('file_insert', $file);
  }
  else {
    drupal_write_record('file', $file, 'fid');
    // Inform modules that the file has been updated.
    module_invoke_all('file_update', $file);
  }

  return $file;
}

@pwolanin: Unfortunately, that page also reads

Note: This function will not work on remote files as the file to be examined must be accessible via the server's filesystem.

I tried it anyway, and now get:

Warning: fstat(): supplied argument is not a valid stream resource in file_save() (line 482 of /var/www/d7-media/includes/file.inc).

What if we call the stream wrapper's ->stream_stat() instead?

oh wait, just saw that's expecting a handler. not sure if i can wrangle that, but i'll work on it this afternoon...

OK, this takes care of the issue. We grab the stream and call ->stream_stat directly. Not sure why PHP isn't doing that natively; probably a PHP bug. Oh well.

local files worked because it was calling filesave() directly on the filename, rather than the stream.

this patch fails now for normal uploads:

Warning: fstat(): supplied argument is not a valid stream resource in DrupalLocalStreamWrapper->stream_stat() (line 392 of /var/www/d7-media/includes/stream_wrappers.inc).

. unfortunately, i guess we'll need to switch on the stream type (drupallocal vs others).

This one works fine with local and remote streams now.

this patch works by opening the stream before reading stream_stat, then closing it. i believe that filesave works the same way for local files, so this shouldn't add anything substantially different functionally. i'm still baffled by stat() not working on the remote stream; maybe dopry can clue us someday into why that's not working as i expected.

huh. well, i used that nearly verbatim, and it still didn't work. note that http://us3.php.net/manual/en/function.filesize.php writes:

As of PHP 5.0.0, this function can also be used with some URL wrappers. Refer to List of Supported Protocols/Wrappers for a listing of which wrappers support stat() family of functionality.

in fact, i'm still unable to get stat() working with my stream... :(

OK, figured it out. I had to implement ->url_stat(). Really confusing. Not sure where ->stream_stat() is even used; i'd earlier interpreted its documentation to mean it was called for stat() functions.