Hi Guys,

Great work so far

I've been testing the latest dev and it still appears that the team member permissions don't do anything at all.

I've tested it using a simple scenario that I have 3 organisations, 1 person per organisation and two teams,
one person is a team member of both teams and the other 2 people are members of the seperate teams respectively.

I've set a role to allow access to storm and access to the necessary child modules with "view own" or "view if assigned to project" and added this to each user.

I can see all projects listed with these settings (although the settings I have in place suggest that I should only be able to see those i'm assigned to) and when trying to click through to the project page I get "You are not authorized to access this page."

Is this still under the knife or should it be working correctly or am I missing something?

Thanks in advance.

CommentFileSizeAuthor
#5 stormteam.module.patch756 bytesMagnity

Comments

Magnity’s picture

Magnity commented

Are any of the users user/1?
Does the role have the permission to administer users?

To confirm - all projects show in lists but none can be viewed?

billshankley’s picture

billshankley commented

Ok to confirm,

No none of the users are user/1

Only the admin (user/1) user can administer users (admin is not one of the team members or persons in storm).

And yes all projects show in the lists but the actual page/nodes are blocked due to access restrictions..

Can you replicate the behaviour or is this just an incorrect concoction of settings?

Magnity’s picture

Magnity commented

Sounds like there is a bug, but I need to follow this up further to be sure...

billshankley’s picture

billshankley commented

Ok, well confirm and I will help test any devs.

Magnity’s picture

Magnity commented
Title: Storm Team Member module permissions not working » Project titles visible for non-assigned teams
Status: Active » Fixed
StatusFileSize
new stormteam.module.patch756 bytes

I think I've found the fault for this - and it should be fixed by the attached patch. I'd be really grateful if you could test and report back.

Meanwhile, I have committed this change to both the 6 & 7 branches.

billshankley’s picture

billshankley commented

Sorry for the delay,

Thanks for the work Magnity, this seems to fix the issue with showing the correct projects when being listed but it doesn't appear to solve the issue of when you try to click on a project listed to see the full project page it still returns "You are not authorized to access this page."

Again, thanks for the work and i'll continue to test any releases.

Magnity’s picture

Magnity commented
Status: Fixed » Active

OK - so the listing is correct, but for any projects listed you cannot see the project page?

billshankley’s picture

billshankley commented

Yes correct.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

All seems to be working fine here. However, I'm not quite sure if the Team module is having any effect on this. I was under the impression that access control is done through the Person module. So, what's the purpose of the Team module? I can only see a node where I can add up to 3 People to one team.

BTW, this issue seems to be related to the 6.x-dev. I wasn't sure so I haven'T changed that yet.

Edit: I grasped a bit more about the Team module and I commented in #585104: Hierarchical permissions with further suggestions.

Magnity’s picture

Magnity commented

The team module should act as a grouping for the persons in the team - so if you assign a project to a team, it is equivilent to assigning to all team-members individually.

(Aside: The team add/edit form will allow you to add 3 new people per edit. At somepoint I'll extend this into proper 'add another teammember js'.)

Magnity’s picture

Magnity commented
Status: Active » Postponed (maintainer needs more info)

@billshankley,

I've just been testing this with the setup of persons, teams and projects from #622732: It's possible to create a task whose internal logic is not respected. (Test site already set up). Unless I've missed something, I don't seem to be able to reproduce a bug now.

Would it be possible to check that you're on the latest -dev release, and post some steps towards reproducing the problem please?

billshankley’s picture

billshankley commented
Status: Postponed (maintainer needs more info) » Fixed

ok to confirm,

Downloaded latest dev and installed on fresh installation of Drupal. All seems to be working as you would expect, apologies for the school boy error.

Marking as fixed

Thanks again.

Magnity’s picture

Magnity commented

All's well that end's well!

Thanks for checking.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.