Log all drupal_set_message() messages

Seems like a good idea to me. The fact that they are not logged is currently kind of mysterious. Logging them all seems more appropriate (principal of least astonishment...)

Hi Moshe,
The _drush_print_log() callback to _drush_log_drupal_messages() (as far as I can tell, the best way to turn regular messages into drush messages for drush batch scripts) doesn't include the "status" message type in its output, but that's the default for drupal_set_message().
The attached patch adds 'status' to the switch().

Thanks,
Ben

That's weird, it didn't output at all for me and I had --verbose on. Let me try again...

So here's my [test] script:

// we want messages at the end
drush_set_context('DRUSH_VERBOSE', TRUE);

drupal_set_message("test", 'status');

// output messages as drush messages
_drush_log_drupal_messages();

I run it with drush php-script SCRIPT and it normally outputs nothing. When I add the 'status' patch it outputs "test" as it should.
So it looks like the default message requires 'debug' to be on, not just verbose. Debug has a lot of extraneous [debugging] output that isn't a "message" per se. I guess it seems that messages should either always output or should output in verbose. My use case was batch-scripting PathAuto which has its own drupal_set_message notices that I wanted to be visible in my script; anything similar calling standard Drupal APIs would probably be the same way.
It's not a huge deal, I can patch it or turn on debugging for my own use case, I was just surprised.

Thanks,
Ben