Modifying product (node) elements such as the sell price, display price, etc. requires these elements to be wrapped in tag with the id="node-$nid". The grid view does not use this identifier and thus makes it impossible to modify elements of a specific node. I know all of this can be accomplished through theming, but I think by default we should at least be able to identify which elements belong to which node.

Cheers,

Antoine

Comments

jantoine’s picture

jantoine commented
Title: Product (node) elements are undistinguishable in grid view by default » By default, product (node) elements are undistinguishable in a multi-product display
Version: 6.x-2.0 » 6.x-2.x-dev

To clarify and expand the problem, by default, product (node) elements such as the sell price, display price, etc. are not themed with an identifier that would allow one to verify which product the element belongs too on a page where multiple products are displayed. Adding an identifier to all elements associated with a product (node) such as class="node-$nid" would allow one to easily identify which product (node) the element belonged to.

Cheers,

Antoine

tr’s picture

tr commented

Yes, this is a good idea. Do you want to roll a patch for it?

tr’s picture

tr commented
Issue tags: +Ubercart theme layer

Tagging

wodenx’s picture

wodenx commented
Version: 6.x-2.x-dev » 7.x-3.x-dev

Bumping to 7.x bc @longwave points out, this is needed for #1380772: Ajax-ify attribute option price selection - it would also be helpful to have an #Id that uniquely identifies each product node on the page - even if it appearsmore than once. I will look into it when I have a chance.

tr’s picture

tr commented

This is already done by the node template - why do we need to do it again?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

We can't rely on node.tpl.php including this information depending on the theme in use. If we add Ajax support for attribute changes we will just end up with a bunch of support requests for people who use badly coded themes that don't include this information.

wodenx’s picture

wodenx commented

DIfferent themes wrap nodes with different classes/id's - just had a user whose nodes were wrapped in id="article-" instead of "node-" -- I guess you could say that was his lookout, but if we want a robust way to update product prices (for example) on the module level, then we need to provide our own identifiers, I think...

wodenx’s picture

wodenx commented

cross-post.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Fixed

This was fixed in #1380772: Ajax-ify attribute option price selection, each product node display has a unique uc-product-N class now.

Status: Fixed » Closed (fixed)
Issue tags: -Ubercart theme layer

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Ubercart theme layer

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.