I was getting errors re: _image_get_vid -- Function not defined --

for cvs image_gallery and shazamgallery

Function has been renamed to _image_gallery_get_vid

Needs to be changed in 3 places. Don't think this is a clean patch, because I've already added some from merlin, but here it is anyhow.

Good luck.

Albert

Comments

Bèr Kessels’s picture

Status: Active » Needs work

This patch is indeed far from clean.

ajwwong’s picture

you're right. still just getting used to the patch thing. :-( probably shouldn't have submitted it.

good luck!

albert

Egon Bianchet’s picture

Status: Needs work » Needs review
StatusFileSize
new1.39 KB

A clean patch

hitka’s picture

In the current shazamgallery cvs version this is already fixed. It has one problem though -- the function not only got renamed, but it is now located in another module -- in image_gallery module.
It would be probably better not to be dependent on this module as shazamgallery is meant as a replacement of image_gallery. But if you need to have this dependency, you should also check for image_gallery module too as you check for image module and probably mention it in the README etc.

Bèr Kessels’s picture

Status: Needs review » Needs work

we we don't want to depnd on that module, indeed.

zach harkey’s picture

Should we duplicate this functionality e.g. _shazamgallery_get_vid () etc.? Or bite the bullet and depend on image_gallery? As it stands, it's been completely broken since May.

Furthermore, if we do duplicate the functionality, should _shazamgallery_get_vid() still get and set $image_gallery_nav_vocabulary or should it use a different variable like $shazamgallery_nav_vocabulary?

zach harkey’s picture

Of course, now that I think about it, if you can't beat em...

Bèr Kessels’s picture

I vote for duplicating the code. No need to depend on a module for only one function. In addition, we need to change the variable names, because otherwise it will create unnecessary conflicts with image_gallery

Egon Bianchet’s picture

StatusFileSize
new2.14 KB

I duplicated the code. We still have to fix the form_alter because the vocabulary is showed both in categories and in the gallery fieldsets. The breadcrumb looks broken too ...

Egon Bianchet’s picture

Status: Needs work » Needs review
StatusFileSize
new2.62 KB

Fixed form_alter