_image_get_vid has been changed to _image_gallery_get_vid in cvs -- should be renamed

This patch is indeed far from clean.

you're right. still just getting used to the patch thing. :-( probably shouldn't have submitted it.

good luck!

albert

A clean patch

In the current shazamgallery cvs version this is already fixed. It has one problem though -- the function not only got renamed, but it is now located in another module -- in image_gallery module.
It would be probably better not to be dependent on this module as shazamgallery is meant as a replacement of image_gallery. But if you need to have this dependency, you should also check for image_gallery module too as you check for image module and probably mention it in the README etc.

we we don't want to depnd on that module, indeed.

Should we duplicate this functionality e.g. _shazamgallery_get_vid () etc.? Or bite the bullet and depend on image_gallery? As it stands, it's been completely broken since May.

Furthermore, if we do duplicate the functionality, should _shazamgallery_get_vid() still get and set $image_gallery_nav_vocabulary or should it use a different variable like $shazamgallery_nav_vocabulary?

Of course, now that I think about it, if you can't beat em...

I vote for duplicating the code. No need to depend on a module for only one function. In addition, we need to change the variable names, because otherwise it will create unnecessary conflicts with image_gallery

I duplicated the code. We still have to fix the form_alter because the vocabulary is showed both in categories and in the gallery fieldsets. The breadcrumb looks broken too ...

Fixed form_alter