The proposed Accessible Content module allows administrators to define collections of accessibility tests (guidelines) and for each content type or CCK field set how those content areas should be checked.
There are several sub-modules, one for exposing accessibility checks via the Services module, another to give themers a tool to preview accessibility problems, and another to provide inline checking of accessibility problems within an editing area.
There have been two posts to the g.d.o/accessibility group (most recently one at http://groups.drupal.org/node/32864) discussing this module, and it seem that the community agrees that this is a separate project from the existing 'Accessible' module, which is much more focused on tweaking Drupal core or other popular contrib modules through theme overrides.
This module will also be a demonstration implementation of the QUAIL (Quail Accessibility Information Library) library which I also maintain over at http://code.google.com/p/quail-lib/ and is covered under GPL 3.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | accessible_content-6.x.tar_.gz | 49.38 KB | Anonymous (not verified) |
| #8 | accessible_content-6.x.tar_.gz | 49.37 KB | Anonymous (not verified) |
| #6 | accessible_content-6.x.tar_.gz | 49.35 KB | Anonymous (not verified) |
| #5 | accessible_content-6.x.tar_.gz | 33.48 KB | Anonymous (not verified) |
| #2 | accessible_content-6.x.tar_.gz | 32.35 KB | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) commentedI'm attaching the proposed module here. Please note that installation will require downloading the Quail library from http://code.google.com/p/quail-lib/ - there's also a note about it in the readme file and on installation.
Comment #2
Anonymous (not verified) commentedIn a momentary lapse of sanity, posted a version with a wayward dvm() in the Accessible Content Services module. Reposting module with core version in the name as well.
Comment #3
avpadernoComment #4
matt2000 commentedIn order to ensure DB portability, you need to use hook_schema to create your database tables, instead of the db_query calls used currently.
Also, you should use node_load($nid) instead of db_query() to take advantage of the static caching that occurs in node_load. See for example, line 345 in your hook_nodeapi
Not a thorough review, just a couple things I noticed quickly.
Comment #5
Anonymous (not verified) commentedAttaching a new version that uses the Schema API for the installation process.
I have also changed to using a standard node module pattern for the accessibility test and guideline nodes instead of just using hook_nodeapi - which will only be used to other nodes that are being run against accessibility guidelines.
Comment #6
Anonymous (not verified) commentedAdding newer version with SimpleTest module and Advanced Help module integration as well.
Comment #7
matt2000 commentedI'm pretty sure you need to check_plain($test->title) in function _accessible_content_add_guideline_form_elements(). Do a scan for any other unsanitized user output (all node data needs to be sanitized before output), then this is RTBC.
Comment #8
Anonymous (not verified) commentedAdded check_plain to the hook_form and hook_views as well as the theme function for highlighting elements.
Comment #9
matt2000 commentedYeah, but you missed the one I mentioned. :-)
accessible_content.module, line 206.
Also, I could be wrong, but I don't think the check is strictly necessary in form element #title's (cf. line 411) as theme_form_element runs it through filter_xss; but this is not the case for theme_checkboxes. But I'd rather see too many checks than not enough. :-)
Comment #10
Anonymous (not verified) commentedYou're right :)
Attaching updated version.
Comment #11
matt2000 commentedUnless l() is specifically told to allow HTML, it will run check_plain for you, so the one on line 369 is redundant. Just FYI, no need to delay further due to that issue.
Comment #12
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #15
avpaderno