This is a patch that adds the ability to configure the list length of users to display that are new.

CommentFileSizeAuthor
#7 whos_new_block.patch4.54 KBAnonymous (not verified)
#5 whos_new_block_count.patch4.08 KBAnonymous (not verified)
#4 whos_new_block_list_count_0.patch3.72 KBAnonymous (not verified)
#2 whos_new_block_list_count1.patch4.08 KBAnonymous (not verified)
whos_new_block_list_count.patch3.72 KBAnonymous (not verified)

Comments

dries’s picture

dries commented
Status: Needs review » Needs work

With this patch, the name of the old max list variable is no longer consistent. It needs to be renamed for clarity.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new whos_new_block_list_count1.patch4.08 KB

let me know if these are better names for the variables.

dries’s picture

dries commented

Better but still not consistent. For the one variable you use ..._list_... while in the other variable you don't. Any particular reason for that?

Also, one small coding style comment: try to use single quotes where possible. It makes for faster code. :)

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new whos_new_block_list_count_0.patch3.72 KB

I rushed through it.. I'm a noob :P

The quote thing, I have a problem with always having to use double quotes which is kinda stupid.

Definitely thanks for the feedback.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new whos_new_block_count.patch4.08 KB

shit.. that was an old patch lol.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Needs work

If we are moving variables around, a system_update_N() needs to be implemented in database/updates.inc to copy over the old data and delete any unused variables.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new whos_new_block.patch4.54 KB

k.. let me know if this is good then.

m3avrck’s picture

m3avrck commented

Code looks good to me.

Only comment might be, we set 5 as default # in list of new users, but we set 10 as the default # of online users. Maybe they both should be 5 by default?

Anonymous’s picture

Anonymous (not verified) commented

i thought of that too but i just kept what the defaults were already.

Anonymous’s picture

Anonymous (not verified) commented

this good to go? also look at http://drupal.org/node/64735 which is very similiar.

LAsan’s picture

LAsan commented
Version: x.y.z » 7.x-dev

Any news about this?

casey’s picture

casey commented
Version: 7.x-dev » 8.x-dev

D7 is in alpha fase already.

darol100’s picture

darol100 commented
Issue summary: View changes
Issue tags: +Needs reroll

Should we move this issue to 9.x? Should we close it and mark it as "Closed wont fix" ? I have attached the tag "Needs reroll" to see if we can get someone to work on this issue.

bill richardson’s picture

bill richardson commented
Status: Needs work » Closed (fixed)

As people is now a view - it should be easy to create a block to show new users if anyone requires it for their site.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Closed (fixed) » Closed (won't fix)

Closing with right status. Can default drupal provides a default 'What's New' block(View block or custom block using plugin) ?