Node and Comment row styles needs to be sure nid/cid is in query before trying to use it

ahh the group by stuff required we remove the automatic base field adding. It appears that the node row style is relying on this field being added automatically.

Here is a patch.

Yes, you are right. I test it without filters and sorts, and for this reason my previous patch worked fine.

New patch.

Wait, no, we no longer want the base field to be added automatically. Instead, I think the row style(s) should be fixed to ensure the fields they need are added.

It is true. I have created a new patch that modified node row (view / rss) and comment (view / rss).

There is another plugin to modify?

Hm. I think things external to the query object should not directly modify that tables. It should use add_field like normal things (and also, styles can have relationships so that can be used to ensure relationship safety as well).

Here is the patch using add_field()

and also, styles can have relationships so that can be used to ensure relationship safety as well

Sorry merlinofchaos, I didn't understand this. Can you explain a bit more your idea? Or this is already done by using add_field?

What I mean is that like fields, styles can have the relationship setting. (yched patched this in so I don't remember precisely how it works).

The example is this: Let's say I want to use the node row style on a nodereferenced node. My argument is for the 'base' node, I add a node reference relationship, and then the style uses that relationship. This turned out to be necessary because sometimes it's hard to get the relationships to work in reverse, properly, so always having the actual node displayed be the base node was a difficult problem.

tagging

Ok, finally I found the mentioned issue #327366: Let row plugins follow relationship and here is a new patch that check if relationship es defined.

With patch #9 and using relathionships I get this query

SELECT node_node_data_field_related.nid AS node_node_data_field_related_nid,
node.nid AS nid
FROM node node 
LEFT JOIN content_type_page node_data_field_related ON node.vid = node_data_field_related.vid
INNER JOIN node node_node_data_field_related ON node_data_field_related.field_related_nid = node_node_data_field_related.nid

With this patch and using relationships

SELECT node_node_data_field_related.nid AS node_node_data_field_related_nid
FROM node node 
LEFT JOIN content_type_page node_data_field_related ON node.vid = node_data_field_related.vid
INNER JOIN node node_node_data_field_related ON node_data_field_related.field_related_nid = node_node_data_field_related.nid

So, it seems to be working fine.

I tested every of this 4 szenarious. Before it didn't worked. Now with the patch it worked fine.

subscribe

I think the only change that needs to be made here is to views_plugin_row::query() which is already doing an add_field() -- I do not believe we need to do this more.

It does seem that a couple of rows (comment and comment_rss) are not relationship safe. That should probably also be fixed.

Here is the patch

Let's test out this patch.

This fixes several row styles to be relationship safe, which is important. Those fixes actually should be backported to Views 2.x as those are serious, though very rarely seen bugs.

Yes, works fine. Even this respect the ability of define relationships in rows plugins.

Needs porting to 7.x -- relies on GROUP BY so needs to wait for that.

remove tag.

Here a patch comes.

For comments and node it worked.

commited