Currently, when generating/rebuilding a query string for use within quicktabs, the module doesn't properly handle arrays within the existing query string.

For example, when using hierarchical select, query strings can look like this:
?tid[hsid]=17&tid[hierarchical_select][selects][0]=label_0

quicktabs then rebuilds this (for use in the tab URLs) as:
?Array

I've attached a patch that seems to resolve this. It uses http_build_query() to build the query string rather than iterating over the $queries variable. I've tested it and it seems to work ok although it needs reviewing just in case it breaks anything. Hopefully this will help someone.

CommentFileSizeAuthor
#2 quicktabs-query-string1.patch868 bytesdeadman
quicktabs-query-string.patch724 bytesdeadman

Comments

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

I think we can use the query as array, no need to create the query string. l() function should handle the query as array since D6. The string conversion code might be a leftover from D5 quicktabs.

@deadman: can you modify the code, that query is used as array? you may also compare it with QT for D7, as it uses the query as array.

deadman’s picture

deadman commented
StatusFileSize
new quicktabs-query-string1.patch868 bytes

Ah even better. Keeping the query string as an array is even tidier!

Here's an improved patch. I haven't checked it against the D7 version yet to see if I'm using the same method, but it works fine for D6 as far as I can tell.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Category: task » bug
Status: Needs review » Fixed

thanks, fixed
http://drupal.org/cvs?commit=292366

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.