I think fb_connect.js (line 11) contains bug. When document is loaded $(this).html() returns empty and next code will not be called. $(this).children().length works more correctly for me.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | patch.diff | 840 bytes | vectoroc |
I think fb_connect.js (line 11) contains bug. When document is loaded $(this).html() returns empty and next code will not be called. $(this).children().length works more correctly for me.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | patch.diff | 840 bytes | vectoroc |
Comments
Comment #1
vectoroc commentedbtw, I don't understand what is this condition for ? If I load via ajax some like (<fb:profile-pic uid=xxx linked=false></fb:profile-pic>) then code under condition will not be called (even $(this).html() or $(this).children().length)
Comment #2
Dave Cohen commentedYou may be right that $(this).children().length is better. I'm no javascript expert and I need suggestions like this to get it right.
What browser are you using?
Try adding the following to FB_Connect.init() at the bottom of the file:
Also I didn't understand your comment. you need to use <code> when posting here.
Comment #3
vectoroc commentedI use Safary, FF. It does not matter.
I believe that this patch is most correct way.
Comment #4
Dave Cohen commentedThanks for this. Just checked it in along with some event binding improvement.