Download & Extend
Bbcode » Issues

bbcode supports tables, and some others but does not mention it in the help

Posted by Nick Brown on November 11, 2009 at 8:26pm
Project:Bbcode
Version:6.x-1.2
Component:User interface
Category:bug report
Priority:minor
Assigned:Unassigned
Status:patch (to be ported)

Issue Summary

While bbcode-filter.inc has table support the bbcode-help.inc file does not mention it.
bbcode-help.inc should be expanded to mention this support.

Login or register to post comments

Comments

#1

Posted by naudefj on December 9, 2009 at 11:44am
Status:active» needs work

Can you please prepare a patch?

#2

Posted by nileshgr on March 23, 2010 at 5:58pm
Title:bbcode suuports table but does not mention it in the help» bbcode supports tables, and some others but does not mention it in the help
Version:master» 6.x-1.2

Its not only table, but there are couple of others too.

I'll be submitting a patch in a day or two.

#3

Posted by nileshgr on March 27, 2010 at 5:23am

Damn me. I wasn't able to spare even five minutes to this job !! :! :!
I will do this asap

#4

Posted by TapSkill on March 27, 2010 at 8:11pm

Help page also needs to mention quotes and how they work.

It would be nice if someone came up with a forum-oriented module to include a "reply with quote" or "reply directly to this user" icon/link, and then, the quote is automatically added in the comment field. It's not necessary, but it would be an awesome module.

#5

Posted by nileshgr on March 28, 2010 at 2:10am

I think you need to check out the quote module here. http://drupal.org/project/quote

#6

Posted by nileshgr on April 3, 2010 at 6:44am
Status:needs work» needs review

I have prepared the patch. Review & commit it.

PS: You will have to specify -R during patching. I think the arguments were misplaced :( and I deleted the modified file :(

AttachmentSize
bbcode-help.patch 3.45 KB

#7

Posted by naudefj on April 3, 2010 at 7:07am
Status:needs review» needs work

Patch is invalid. It deletes a bunch of lines that isn't in the file (wrong way diff maybe?)

#8

Posted by nileshgr on April 3, 2010 at 2:34pm

It is valid, see the attached image -

Ignore that Ctrl-C, it was a typo.

AttachmentSize
snapshot2.png 37.01 KB

#9

Posted by naudefj on April 3, 2010 at 2:54pm

$ patch -p0 -li bbcode-help.patch          
patching file bbcode-help.inc                                        
Reversed (or previously applied) patch detected!  Assume -R? [n] y   
Hunk #3 FAILED at 238.                                               
1 out of 3 hunks FAILED -- saving rejects to file bbcode-help.inc.rej

If you cannot do another diff, please upload the entire updated file.

#10

Posted by nileshgr on April 3, 2010 at 4:39pm

Its very funny though. I think you're using the CVS version. With 6.x-1.2, the patch works as I showed it in the screenshot.
Here's the complete file :)

AttachmentSize
bbcode-help.inc_.txt 14.63 KB

#11

Posted by nileshgr on April 3, 2010 at 4:53pm

Hi, it seems the Abbreviations and Acronyms part got repeated, as the help file already had them.

Here's the patch and the new file :)

AttachmentSize
bbcode-help.inc_.txt 14.34 KB
bbcode-help.patch 3.16 KB

#12

Posted by nileshgr on April 3, 2010 at 4:57pm

Sheesh. Bugs bugs bugs. I *hope* this is the final.

AttachmentSize
bbcode-help-final.patch 3.15 KB
bbcode-help-final.inc_.txt 14.34 KB

#13

Posted by naudefj on April 3, 2010 at 4:59pm
Status:needs work» patch (to be ported)

Yes, it's clashing with http://drupalcode.org/viewvc/drupal/contributions/modules/bbcode/bbcode-...

I'll merge it in later.