menu links are weird if users have 'admin signups' but not 'administer site configuration' permissions

eureka! option 2a: just conditionally rename the titles of these links depending on if the user has 'administer site configuration' permissions or not. ;) i think this is the best possible solution. unless there are any strong objections, i'll commit this to all branches.

according to http://api.drupal.org/api/HEAD/function/hook_menu:

may_cache -- A boolean indicating whether cacheable menu items should be returned. The menu cache is per-user, so items can be cached so long as they are not dependent on the user's current location.

i think it's pretty reasonable to assume that a given user's roles aren't going to be changing so fast that this is really a problem if it's cached. i mean, this is a rare case in the first place, and i don't believe it really matters that if a) they just have admin signups and they cache the link titles as "signup settings" b) they get added as site admins and c) they go to admin/settings and see "signup settings" before the cache is refreshed. seems like an insanely rare situation for a problem that really isn't a big deal (so they see the extra word?). in fact, consider it a feature, since if they're used to the old (verbose) links when they first get added as full site admins, it'll help them find the old links in the new locations. ;)

anyway, given that the menu cache is per-user, i don't see that as a good reason not to go ahead and commit. am i missing something?

argh, damn ':' got included in that URL. here's the docs on hook_menu:
http://api.drupal.org/api/HEAD/function/hook_menu

according to merlinofchaos in IRC, whenever a user's profile is edited (e.g. to change roles), once the submit happens, the menu cache is cleared. see user.module:

function user_edit_submit($form_id, $form_values) {
...
  user_save($account, $form_values, $category);
  // Delete that user's menu cache.
  cache_clear_all('menu:'. $account->uid, TRUE);
  drupal_set_message(t('The changes have been saved.'));
  return 'user/'. $account->uid;
}

also, if roles are modified to change what permissions are in a given role, *all* cached menus are cleared, and the entire menu rebuilt:

function user_admin_perm_submit($form_id, $edit) {
...
  drupal_set_message(t('The changes have been saved.'));

  // Clear the cached pages and menus:
  menu_rebuild();

}

so, i think we're safe. agree?

applied to HEAD, 4.7 and 4.6.