A new security release of the rootcandy theme came out, which I use as the administration theme on a number of my sites. So I ran drush update to upgrade the code, but it didn't do anything. The administration theme didn't appear in the list of modules / themes it was checking as the theme itself isn't enabled on the site. You can still configure an administration theme that isn't one of the ones enabled. Perhaps a special check needs to be done for this setting too?

Cheers,
Stella

Comments

moshe weitzman’s picture

moshe weitzman commented

Thats very dodgy behavior of core to allow disabled theme to be used. We are overcoming a UI desire in the wrong away IMO

stella’s picture

stella commented

Hmmm I could see one use-case for it. Say you were using Root Candy or another admin theme on the site that you didn't want available to the general public, but you still wanted users to pick their own theme using the switchtheme module or in their profile - then you wouldn't want to enable the admin theme. There's probably a better way to control that though, but I imagine it is one valid use case.

moshe weitzman’s picture

moshe weitzman commented

Right. Thats what I cryptically meant by "we are overcoming a UI desire in the wrong way". we need to be able to hide active themes from end users, but allowing disabled themes to be used is wrong, IMO.

Still, this needs sorting in drush since drupal is changing its mind soon.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented

Drupal does neither do the check for update availables for the admin theme if it is not enabled. It doesn't seem hard to implement in drush though.

greg.1.anderson’s picture

greg.1.anderson commented
Version: » 8.x-6.x-dev
Component: Code » Base system (internal API)
Status: Active » Closed (won't fix)
Issue tags: +Needs migration

This issue was marked closed (won't fix) because Drush has moved to Github.

If desired, you may copy this bug to our Github project and then post a link here to the new issue. Please also change the status of this issue to closed (duplicate).

Please ask support questions on Drupal Answers.