Admin settings page

CommentFileSizeAuthor
#3 lazy_image_loader.zip9.98 KBAnonymous (not verified)

Comments

Anonymous’s picture

My 2 cents:

- allow integration with imagecache presets: so you can choose which images are lazy loaded (can be done by css class, e.g. $('img.imagecache-preset1');)
- allow admin settings for fade-in/preloader, custom bg color

Anonymous’s picture

I really like this module, it work perfectly integrated with either imgcache, or allow to set custom img classes (in a textarea box, 1 class per line). You could add it easily to

$(function() {          
				$(".content img, .imgcache-presetx1, .imgcache-presetx2")

If you need some help, let me know. I'd be happy to work on the admin settings page! I could make a patch for it coming weeks.

Anonymous’s picture

StatusFileSize
new9.98 KB

I decided to build on your module, see attached . it has admin settings for css classes, threshold, event, effect and failurelimit.

sinasalek’s picture

Status: Active » Postponed (maintainer needs more info)

Very nice , Thanks @morningtime for the great contribution.
There is a new release beta1 which contains several changes (No admin settings yet).

I'm reviewing your patch , you've changed module's dependency to image module. but it can be optional since it works for any kind of image anywhere, for example for pages generated with views or images integrated into theme.
You also removed _lazy_image_loading_page_match (it wasn't working on D6.x version i'm aware of that) function which means that the javascript will be included on every page which is not appropriate in my opinion.

Let me know you opinion.

I really like this module

Glad to hear that ;)

Anonymous’s picture

Yeah image is optional, I put the menu link as a tab for image, but thats not really important.

page_match is something to figure out, I haven't really looked at it yet!

sinasalek’s picture

It used to work on D5, but i didn't port it completely to D6 so i had to disable it, it'll be functional in the next release.

sinasalek’s picture

Status: Postponed (maintainer needs more info) » Active
sinasalek’s picture

Status: Active » Fixed
sinasalek’s picture

@morningtime, let me now if you've used this the new 1.1 version and it works for you. i'm about to make the stable release

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sinasalek’s picture

Issue tags: +6.x-1.2 Roadmap

Marked

sinasalek’s picture

Marked