Closed (won't fix)
Project:
Helpers
Version:
master
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 May 2006 at 22:35 UTC
Updated:
29 Apr 2010 at 00:54 UTC
I've put some work into this module, so here is my try...
(Note: due to the massive number of changes this is the complete package and not a patch.)
Changes:
| Comment | File | Size | Author |
|---|---|---|---|
| helpers-smk.tar.gz | 12.31 KB | smk-ka |
Comments
Comment #1
ymcp commentedThere is a selection of free flags available at the Open Clip Art Library.
Comment #2
ymcp commentedThe KDE project also has a good selection of GPL flags in their "localization" project area. You can browse through the online svn repository for a particular flag, or download the entire (20+ Mb) kdebase tar-ball, and extract all the files called "flag.png".
Comment #3
Bèr Kessels commentedThis looks extremely usefull to me. However, the tarball looks strange to me and is not in the form of a patch, wich makes it hard for me.
Would it be an idea to move this into a helpers_locales.module or some other name? Where we can stick all the helpers that have to do with flags, countries, states, country iso code etc?
And the patch: please refer to drupal.org/diffandpatch for how to make a patch.
The tarball contains a directory flags wich -as you explain- is empty. I'd rather leave that directory out then all together.
So far nice work, though.
Comment #4
sun+1 for modularization
Currencies would also belong in helpers_locale.module.
Comment #5
csc4 commentedCould this be tied together with the projects location (which seems to be duplicating the region work) and ip2cc (which has extensive regionality and flags at http://ip-to-country.webhosting.info/node/view/91) ?
Comment #6
smk-ka commentedYes, especially as the location module already includes a list of provinces/regions for each country. I'll take a closer look at what's missing from here in the location.module in the near future, and create the proposed location_helper.module. For example, I'm planning to extend either the location or gmap module with a list of average country (and additionally continent) coordinates, which can be used to zoom a country/continent on a Google Map even for anonymous users, using the country code resolved by ip2cc.
I'll leave this issue open until something finally starts moving in that direction.
--
Stefan Kudwien
www.unleashedmind.com
Comment #7
csc4 commentedThat sounds brilliant - especially if you can magic up some UK support too. Thanks, I'll keep watching progress.
Comment #8
Bèr Kessels commentedJust a short note to let you all know that I am following this thread with envy: I'd love to see this implemented properly.
Comment #11
coupet commentedgreat start, wish we were further along as originally planned.
Comment #12
nancydruHi, all. We now have an active maintainer to help Bèr; we also now have a 5.x version.
What is the status on these patches or interfaces?
Comment #14
nancydruWell, sunyapeng2006, forgot the attachment. And smk-ka promised a location interface, which I don't see yet.
Right now, I'm still trying to get more comfortable with these modules by producing decent documentation (see the link on the project page).
Comment #15
smk-ka commentedWell, region and country lists and their associated ui elements certainly better fit in some geo module, or a submodule which handles address storage and display.
Average continent and country coordinates (probably together with a specific zoom value for each entry) should definitively be implemented as part of a geocoding component. With bdragon as the new maintainer of Location we hopefully see that module advance in the right direction so this feature could be added (with country data hard-coded as php arrays this isn't really possible now).
So, the only thing that's left over here is the country flag theme function.
Comment #16
nancydruI look forward to seeing that and any patches that come from it.
In case no one has noticed, there is now 6.x support.
Comment #17
giorgio79 commentedHow about this one?
http://www.famfamfam.com/lab/icons/flags/
Comment #18
nancydruYes, I have seen that set. However, we still have the debate over which module should be doing this.
Comment #19
nancydruWhen the patches are ready, reopen this issue.