gibus [gibus]

PS: in this CVS application form, I've check "I will only commit code that is licensed under terms of the GNU public license, version 2", while the 'Priorities' module, as well as any future module, is supposed to be released under GPLv3 or later.

As you approved, you can only release a module under GNU License v2, which is the same license used by Drupal. As the module depends from Drupal code, module and Drupal must use the same license.

It's not clear what the code is doing in priorities_enable(), which should go in priorities.install.

I still don't understand why the code should rebuild the menus all times it is enabled.
Then, what are the vantages of using this module, rather than using a vocabulary?

1.     $link['mlid'] = 0;
       $link['link_title'] = t('@title', array('@title', $priorities['title']));
   

   A string with just placeholders doesn't contain anything that can be translated; the call to t() is useless.

2. function priorities_uninstall() {
     drupal_uninstall_schema('priorities');
     db_query("DELETE FROM {variable} WHERE name LIKE 'priorities_%'");
   }
   

   It is better to explicitly delete all the Drupal variables defined from the module with variable_del(). There could be other modules with a name starting with priorities_.

3. See the Drupal coding standards to understand how a module code should be written. In particular see the namespace respect part.

I apologize for the delay in the approval.
I am still not convinced about the module, but I will let the users judge about that.