Hi,

I have encountered a bug in a function delegate_menu_admin_form_alter(), in this function if a user does not have "administer some menu" and "administer menu" permissions, still that user is being checked for each and every menu item access which seems unnecessary.

This form alter hook should only work if a user has "administer some menu" permission. otherwise if we have a menu item that holds more than 500 menu items, then the node form will take around 5-15 mins to load

I am also attaching a patch to fix this issue

CommentFileSizeAuthor
delegate_menu_admin.patch616 bytesqandeel

Comments

justindodge’s picture

justindodge commented

Committed to 6.x-1.x-dev branch

qandeel’s picture

qandeel commented

Thanks for the update

qandeel’s picture

qandeel commented

hi, i noticed that you committed the patch and its saying applied patch by unknown... Atleast it should show my name that i have contributed and spend time on this module.. :(

justindodge’s picture

justindodge commented

Sorry Qandeel, I haven't gotten many patches for my modules, and for the ones I have, I've never had someone care about the credit, so I am not in the habit of adding authorship to the commits.

I will add a dummy commit with a note about your contribution, your authorship added, and a reference to the issue as soon as my current working changes are ready to be added.

I'll try to keep in mind that it's important for the future, as I want to encourage people submitting patches as much as possible.

Thanks for contributing!!

qandeel’s picture

qandeel commented

thanks justindodge, I really appreciate your perspective on contributing codes.

qandeel’s picture

qandeel commented

Please see this article on drupal to commit patches and how they differ from owner and committer:
http://drupal.org/node/1146430

also you can amend the last commit and make changes to author like this...
git commit --amend --author="qandeel "

justindodge’s picture

justindodge commented

Thanks for the link, I actually read it after your initial post - unfortunately git commit --amend only works when you still only have the changes on your local repo. Once they get pushed/published, changing the commit history is problematic.

Not to worry though, I will simply add a crediting commit.