Posted by Qandeel on November 12, 2009 at 4:08pm
2 followers
Jump to:
| Project: | Delegate Menu Administration |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
Hi,
I have encountered a bug in a function delegate_menu_admin_form_alter(), in this function if a user does not have "administer some menu" and "administer menu" permissions, still that user is being checked for each and every menu item access which seems unnecessary.
This form alter hook should only work if a user has "administer some menu" permission. otherwise if we have a menu item that holds more than 500 menu items, then the node form will take around 5-15 mins to load
I am also attaching a patch to fix this issue
| Attachment | Size |
|---|---|
| delegate_menu_admin.patch | 616 bytes |
Comments
#1
Committed to 6.x-1.x-dev branch
#2
Thanks for the update
#3
hi, i noticed that you committed the patch and its saying applied patch by unknown... Atleast it should show my name that i have contributed and spend time on this module.. :(
#4
Sorry Qandeel, I haven't gotten many patches for my modules, and for the ones I have, I've never had someone care about the credit, so I am not in the habit of adding authorship to the commits.
I will add a dummy commit with a note about your contribution, your authorship added, and a reference to the issue as soon as my current working changes are ready to be added.
I'll try to keep in mind that it's important for the future, as I want to encourage people submitting patches as much as possible.
Thanks for contributing!!
#5
thanks justindodge, I really appreciate your perspective on contributing codes.
#6
Please see this article on drupal to commit patches and how they differ from owner and committer:
http://drupal.org/node/1146430
also you can amend the last commit and make changes to author like this...
git commit --amend --author="qandeel "
#7
Thanks for the link, I actually read it after your initial post - unfortunately git commit --amend only works when you still only have the changes on your local repo. Once they get pushed/published, changing the commit history is problematic.
Not to worry though, I will simply add a crediting commit.