The schema module is complaining about this module's declared database schema:

viewreference.view_id is part of the primary key but is not specified to be 'not null'.

CommentFileSizeAuthor
viewreference-DRUPAL-6--2_view_vid_not_null.patch1.02 KBdboulet

Comments

danielb’s picture

danielb commented

You are just reversing the work done in response to this issue: http://drupal.org/node/386268
I'm thinking we need a separate primary key or something different to solve both issues.

dboulet’s picture

dboulet commented
Title: view_id column should be declared as 'not null' » view_id is part of the primary key but is not specified to be 'not null'.

Thanks, I hadn't seen that other issue. Yes, it seems then that my patch won't do, and some other solution will have to be found.

danielb’s picture

danielb commented

It seems to me that your patch, and this module's schema's original design is correct. It is CCK attempting to record a null value that is pointless, and there may be a spot elsewhere in viewreference's code that could be altered to prevent this?

danielb’s picture

danielb commented
Status: Needs review » Fixed

I've readded 'not null' => TRUE, and put an 'if' test before the insert query, this will hopefully prevent it trying to write null values without creating any new problems.
It will appear in the next dev snapshot.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.