Prevent pathauto_cleanstring() from creating empty components

I used the user profile pattern 'members/[user-raw]' and registered a new user on my site, and it worked just fine for me. Can you give this a try with the latest code and double check your URL alias patterns?

I think this is a "words to remove" problem because of the username "a."

I guess Pathauto should do something different if the only words in a string are words to remove?

Better title and marking #724894: characters are not changed nor working as a duplicate.

Marked #727302: If node title contains only ignore words, it results to a blank alias as a duplicate. Also, I'm guessing this applies to 7.x-1.x as well.

I would like to suggest for the fix of this issue: Optionally we can left the alias untounched to avoid blank alias if component contains only the ignore words. Here's the suggestion fix for pathauto.inc starting line 183:

-  if (function_exists('mb_eregi_replace')) {
-    $output = mb_eregi_replace($ignore_re, '', $output);
+	// If element contains only the ignore words, left the alias untounched to avoid blank alias
+  if (function_exists('mb_eregi_replace')) {	
+	 $temp_output = trim(mb_eregi_replace($ignore_re, '', $output));
   }
   else {
-    $output = preg_replace("/$ignore_re/i", '', $output);
+	 $temp_output = trim(preg_replace("/$ignore_re/i", '', $output));
   }
+	$words = preg_replace('/ |' . $separator . '/', '', $temp_output);
+	if (strlen($words)) {
+	 $output = $temp_output;	
+	}

I really like this idea of checking if the output will be an empty string, then don't use the replaced-word-output. This will need a test to confirm it works and stays working though.

Sure of course we need to test it. Although I made my own testing and it works fine but only for nodes. Others like taxonomy, user-tracker and user path I only assume their auto path routine work the same as nodes.

Initial patch with small test for D7.

Better title

After this gets reviewed and committed to Drupal 7.

I appreciate your enthusiasm, but the best thing to move it forward is a patch review.

Committed this patch to all three branches!

http://drupal.org/cvs?commit=385358
http://drupal.org/cvs?commit=385364
http://drupal.org/cvs?commit=385366