Language switcher block does not handle a single link correctly

The attached patch fixes the wrong condition and integrates Locale tests to detect this failure.

Cleaning-up the "locale module" issue queue as per http://cyrve.com/criticals.

rerolled

Related issue: #778528: Define the language switcher's correct behavior.

#3: locale-631928-3.patch queued for re-testing.

@GiorgiosK:

#3 patch does not work as advertised
2 language links are presented for a tranlatable node with no translation

This is the D6 behavior and is not covered by this issue, #518364: Nodes with one language don't affect the language switcher block addresses it.

Steps to reproduce/test this:

1. Enable two languages, say EN and IT
2. Enable URL language detection
3. Enable translation for articles
4. Enable the language switcher block
5. Create an article in EN and translate it in IT
6. Unpublish the IT translation
7. Visit the EN node with EN as interface language. Expected behavior: the language switcher block disappears.
8. Visit the EN node with IT as interface language. Expected behavior: the language switcher block shows a link to the EN node with EN as interface language.

@GiorgosK:

They are not the same issue, so we need two separate ones.

The fact that the patch passes its own test suggests that it's working. You are seeing "access denied" because you are using D7 beta1, while the fix is against the HEAD. I tested the path in #10 with a fresh HEAD checkout this morning before posting it. Correct unpublished translations handling did not get into D7 beta1.

Please be sure to have the latest code before changing the status again.

@GiorgiosK:

Thanks for your patience :)

rerolled

@webchick:

Well this issue fixes the general behavior of the language switcher, while the other one concerns the relation between the language switcher and the Translation module. As we discussed in IRC, IMO if there is only a single link available and it matches the current language the correct behavior is hiding the block. It's up to modules implementing http://api.drupal.org/api/function/hook_language_switch_links_alter/7 to avoid this situation if it's not the desired behavior.

Anyway, we can mark this duplicate of the other one, but IMO we have two independent, although strictly related, discussions to bring on.

Edit: the tests here won't be modified by what we decide in the other issue.

Another possibility is that, since the only core module actually dealing with the language switcher block is Translation, we remove the condition on the links number altogether:

<?php
  if (isset($links->links) && count($links->links) > 1) {
?>

becomes

<?php
  if (isset($links->links)) {
?>

This way we would allow other modules to implement self-hiding blocks through http://api.drupal.org/api/function/language_negotiation_get_switch_links/7, which encapsulates most of the logic needed to generate a language switcher block.

@webchick:

Also, removing "Quick fix" because it's a LIE. ;)

I was in good faith :)

I didn't think we would end up in an architectural discussion, I just wanted to fix that damn parenthesis.

As suggested by GiorgiosK and webchick, this has been fixed in #518364: Nodes with one language don't affect the language switcher block.