Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
rdf.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Nov 2009 at 16:43 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
scor commentedpatch with tests
Comment #2
moshe weitzman commentedshould check for access comments permission?
Comment #3
Anonymous (not verified) commentedChecks for 'access comments' permission.
Comment #4
Anonymous (not verified) commentedComment #5
dries commentedCurious -- shouldn't the permission span all the code instead just the meta tag in the page header?
Comment #6
moshe weitzman commentednext question. can this code live in a node_preprocess_node() instead of rdf_preprocess_node()?
Comment #7
scor commented@Dries: we test for
isset($variables['content']['links']['comment']['#links']['comment_comments'])which returns false if the user does not have access to comments.@Moshe: do you mean template_preprocess_node()? I'm not opposed to it, and this remark could apply to more code in rdf_preprocess_node(). So far we've tried to keep the RDFa logic in rdf.module as much as possible but effulgentsia or sun mentioned it to the respective template function. At the end of the day you would still need to check whether the RDF module is enabled though. Would it bring much performance improvement?
The patch adds a line of documentation above number of comments annotation code.
Comment #8
moshe weitzman commentedI said node_preprocess_node, not template_preprocess_node. but i see your point about checking for rdf module. i am ok with rdf_preprocess_node.
Comment #9
mlncn commented<meta about="/d7rdfa/node/1" property="sioc:num_replies" content="3" />It looks beautiful, and it can count, too!
Comment #10
scor commentedrerolling patch.
Comment #11
dries commentedCommitted to CVS HEAD. Thanks!
Comment #12
scor commentedThanks Dries, nice to see you looking at these RDF issues - keep the ball rolling, there are a few more looking for your attention including the beast #538164: Comment body as field ;)