Posted by joachim on November 13, 2009 at 6:35pm
5 followers
Issue Summary
Shortcut module puts a form for settings alongside my user account at user/%user/shortcuts
This is wrong.
Things I can edit that are to do with my account and my personal use of Drupal go below user/%user/edit -- such as which theme I use, which blocks I see, etc.
The shortcuts form should either go below user/%user/edit as a tab, or as a fieldset inside user/%user/edit.
I think the latter is preferable, as it's a form with just a single field.
Comments
#1
I'm not sure that this is a critical issue ... but I agree that the user shortcut settings should be moved. This patch does exactly that...
#2
Here testbot ... here boy
#3
I had a small error in my original patch ("edit" links were not working properly next to the shortcut set names) ... this patch fixes it
#4
Blaaarg! Whitespace (I swear I'm getting better about this)
#5
adding tag so it shows up in usability queue (not sure why #d7ux didn't do the trick)
#6
Subscribing. It does seem to make sense to at least make it a tab.
I haven't looked too carefully at the patch, but there's a bit of a tricky issue here - for site administrators, they need to sometimes be able to view shortcut sets outside of the context of an individual user account, whereas for non-site-administrators, they need to be able to have a clear place that they get redirected to (within their user account) to when they click the "edit shortcuts" link in the toolbar.
Also, to the extent that an overall strategy for the UI is being discussed at #680500: Shortcuts violate Drupal UI standards, that issue is probably relevant for this one.
#7
Just as a note: The OpenID module also puts its form on the same level as the existing Shortcuts module. So if you are going to make this fix, it should apply to OpenID as well. Both are doing similar things (editing settings related to your acocunt).
#8
That's true, and contrib modules put a lot of editable things up there too. It's not clear there's an overall standard. Basically, in the absence of a standard, it seems like only things that are supposed to be "visible" should be in the top level like that.
Probably neither shortcuts nor OpenID need to be particularly visible, so could be underneath the edit page, as its own tab.
#9
clearly this isnt happening in D7
#10
From my point of view this is the correct decision, we want to core adhere to this standard. If we can get a code review on this its RTBC from me.
#11
What is strange, is that we are moving something which was a page, to something that is just a form. We will need to increase the usability of this thing if we want to do that.