I would have submitted this, but as it's a bit of a change, I'd rather let you review it first.

I was working on reporting line items, and I am using other modules that adds line items to orders (besides tax and shipping), so I did a module that gathers all line items from ubercart and feed that to views. If new line items are added, the views cache has to be rebuilt, but that's not a huge compromise. Old tax and shipping should work exactly the same. I changed the group for line items to "Ubercart order line item".

I also improved the money amount handler to use a better one from ubercart. Refer to #578334: uc_product price views bugfix and one small enhancement for more information, but basically I submitted a patch that got accepted that let you use the price field either as a numeric value or as an ubercart price. There's still a bug in ubercart on that price handler, but it only affects numeric formatting so basic uc_price will still work with the new improvements. I have submitted a new patch for ubercart with that fixed and also a slight improvement which this modules will also take advantage once committed.d

CommentFileSizeAuthor
order_line_items_and_price_handler.patch6.57 KBhanoii

Comments

hanoii’s picture

Just wondering if you had a chance to look at this, shall I commit it myself? The patch for ubercart was accepted and committed.

madsph’s picture

Sorry for not getting back to you.

I were away on a conference and right when I got back I fell of a horse and broke my leg (have spent a week in hospital cause the leg needed surgery).

Right now I am lying in my bed with the leg raised and working through the pile of work that has emerged in the passed two weeks.

That is why I have limited my presence in the forum to only handle support requests.

As always - your ideas sound really great. And I am excited to see them in practice.
If you have tested this I am comfortable with you applying the patch.

hanoii’s picture

Status: Needs review » Fixed

Committed.

I hope you are doing well (or better?). And out of curiosity, do you do any horse related sport or was just a fun occasional ride?

madsph’s picture

I am doing better - Thanks :-)

I took up horse back riding when my daughter and wife started, so I am still pretty new at this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.