Closed (fixed)
Project:
Service links
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Nov 2009 at 22:12 UTC
Updated:
28 Nov 2009 at 00:50 UTC
It's hard to say whether this really is a service links bug because the actual bug I'm dealing with is in Share This module. Here's how to reproduce the problem:
The problem undoubtedly arises from a bug in the external sharethis js code but it's very difficult to debug. And anyway it seems wrong for this external js code to be getting loaded when the node is being edited. But service_links_render(), which calls the share this callback, which adds this js, is being called on node_load.
I attach a patch that checks for arg(2) == 'edit' before rendering the service links. It solves the problem for me but maybe it's not the best solution. Thoughts?
| Comment | File | Size | Author |
|---|---|---|---|
| service_links_node_edit.patch | 1.18 KB | katbailey |
Comments
Comment #1
robloachYay! Thanks :-) .... http://drupal.org/cvs?commit=288822