Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
rdf.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Nov 2009 at 01:37 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
scor commentedand here is a simple patch which should not cause any trouble to the bot.
Comment #2
Anonymous (not verified) commentedI wonder if we might want to use media:image for the image predicate instead. Right now, it implies that the image depicts the node, which I'm not sure is accurate.
Here are the specs for comparison:
Comment #3
Anonymous (not verified) commentedI discussed this with cygri, he also believes that foaf:depiction is not quite accurate here since the image isn't really a visual depiction of the node itself or even necessarily a depiction of the concept talked about in the node.
He recommended looking for a predicate that is closer to a 'featured image' concept, but said that a safe fallback would be the generic dc:related. The only thing I could find was hasPageImage from the document vocabulary of Mindswap, but I don't think that is widely deployed.
In addition to whatever main predicate we use, I think we should also include media:image. GoodRelations does this, citing is as a Yahoo! recommendation (which probably means something for Search Monkey results).
Comment #4
scor commentedThat's great. I'm fine with either, as long as we have something to relate the image to the node :) feel free to reroll.
Comment #5
Anonymous (not verified) commentedThis uses dc:relation and media:image to annotate the relationship between node and image.
Because dc:relation is general, we should make the rdf type explicit (ie foaf:Image). I have created an issue, #642596: Annotate images with RDFa 'typeof'
Comment #6
scor commentedI can't dereference
http://purl.org/media#image.rapper -g http://purl.org/media# | grep imagereturns only the triple:which is not what I expected. Lin, can you point me to the document where you found a definition for media:image?
Comment #7
scor commentedI'd like to settle on
rdfs:seeAlsofor the description of the image. I'm not happy with the Yahoo! media vocabulary because it does not dereference, and SearchMonkey seems to understand rdfs:seeAlso anyways.Comment #8
scor commentedI think
sioc:topicmight be more appropriate here, SearchMonkey recognizes this property as part of the Discussion objects. Also the domain offoaf:topicisfoaf:Document, which means that if we want to describedsioc:Items for example we need something more generic likesioc:topicwhich has no domain restriction.Comment #9
Anonymous (not verified) commentedGood point about sioc:topic.
I removed media:image. I also replaced dc:relation with rdfs:seeAlso because they are similar in how general they are.
Because rdfs:seeAlso is so general, it makes #642596: Annotate images with RDFa 'typeof' all the more important. I forgot that I was going to write a basic test for that, will work on it soon.
Comment #10
Anonymous (not verified) commentedComment #13
scor commentedlooks good. RTBC
Comment #15
scor commentedThis will need a reroll since profiles/default/default.install was renamed to profiles/standard/standard.install in #420358: Write clear install profile descriptions.
Comment #16
aspilicious commentedI'll try this...
apparently this isn't working...
What am i doing wrong...
Comment #17
aspilicious commentedmaybe "patch" isn't allow in name?
EDIT: i give up
Comment #18
lilou commentedComment #19
aspilicious commentedgreen
Comment #20
webchickCould someone please change the tabs => spaces and re-upload?
Comment #21
aspilicious commentedAnother try, srry webchick.
Hopefully this is a good one...
Comment #22
aspilicious commentedneeds testbot review
Comment #23
scor commentedaspilicious : Great to see you posting your first patch. The indentation of the context line 'rdftype' is not right and the patch does not apply. Did you edit the patch file? If so, that's not recommended, you should only edit the actual files (standard.install here), roll the patch (with cvs diff) and post it. The best way to reroll this patch is to edit standard.install and paste the following right after
'rdftype' => array('sioc:Item', 'foaf:Document'),:With some context, standard.install should look like:
Comment #24
aspilicious commentedthnx scor...
so maybe this one works lol
Comment #25
aspilicious commentedComment #26
scor commentedYour editor might be messing up the indentation. According to the Drupal coding standards, you should use 2 spaces for indenting (not 4 spaces). The indentation of the 4 four lines 'predicates'..., 'type'..., 'predicates'..., 'type'... need to be fixed (remove 2 spaces from each).
Powered by Dreditor.
Comment #27
aspilicious commentedIm wondering how many times i gotta do this again...
Thnx for your patience!
Comment #28
aspilicious commentedcertainly one more time
Comment #30
aspilicious commentedI rly suck in committing a fucking easy patch!
Fuck windows endings
Fuck tabs
Fuck 4 spaces
Maybe shouting works....
Comment #31
aspilicious commentedComment #32
scor commentedI can't help you since I'm not a Windows user, but you could look at http://drupal.org/node/323 and http://drupal.org/node/60234 to learn how to roll patches on Windows. However this patch applies and looks good, let's wait for the testing bot results.
Comment #33
aspilicious commentedMHHAHAHAHAHAHAHAHAHAHHAHAHA
Comment #34
scor commented@aspilicious: it's generally frown upon to RTBC your own patch: the "needs review" status is not only for the testing bot, but also and foremost for other people from the community to review the patches. Peer review is what makes Drupal core code better quality, and it also saves time for webchick and Dries since other people are likely to catch bugs, typos, coding standards etc.
I'm going to leave this as "needs review" for now as I'm just thinking we might want to also add sioc:Post as rdftype of article.
Comment #35
aspilicious commentedsrry, i'll be slower....
Comment #36
Anonymous (not verified) commentedInitially, I agreed about sioc:Post, but reviewing the definition of sioc:Post this morning changed my mind.
It seems that sioc:Post is really focused on community sites. For instance, in the definition of sioc:Item, it says "[A subclass of sioc:Item is] sioc:Post, used to describe articles or messages created within online community Sites." sioc:Posts are also supposed to be submitted to a forum, and the definition of forum implies interactivity.
In contrast, I can see a lot of people using the Article content type as a container for their news and press releases on brochure-ware sites and turning off comments, so I think this might stretch the definition.
Comment #37
scor commentedI agree article will be used to many different use cases and we cannot know in advance what people will use it for, hence we need to keep the mapping generic. The only thing we know almost for sure is that it'll have comments enabled and thus enable some form of discussion (though not in a forum setting you Lin points out). Many will use it as a single user blog I think, though that's just one use case out of many.
Comment #38
Anonymous (not verified) commentedThe user might also turn off comments on the Article type—I know I did that frequently for University department sites, using the default Story content type with comments turned off for the News section.
Comment #39
scor commentedright, so really we can't be more specific here wrt to the mapping, and it's best to let the user choose more specific mappings (if she cares to do so) via the rdf contrib module.
Comment #40
scor commentedWhen are we required to implement update functions for non code changes? if it's after the first alpha release, then we should really get this patch committed before Friday: the RDF mappings are stored in the db upon installation.
Comment #41
scor commentedrerolled patch.
Comment #42
dries commentedCommitted to CVS HEAD. Thanks.
Comment #44
scor commentedThis is a follow up on the best way to describe the relation between a node and its image as discussed in #2 onwards. At the time there was no explicit property to link an article to its featured image, but with the Open Graph protocol, we now have
og:imagewhich matches this use case perfectly.Comment #45
Anonymous (not verified) commentedGood call, this does seem to be a fit. The OG namespace doesn't dereference, but I checked the docs and the namespace is correct.
RTBC.
Comment #46
scor commented@linclark, I'm working with the Facebook team to fix the namespace which should dereference pretty soon. This doesn't hold up this patch though.
Comment #47
dries commentedCommitted to CVS HEAD. Thanks.
Comment #48
gábor hojtsySubmitted a head2head issue at #862742: #632484: new RDF mappings added to existing fields.