In taxonomy_link if taxonomy_term_path returns a path that includes a query or fragment, the links that get created are messed up.
This can be fixed by splitting the url from taxonomy_term_path before using it to create the link.
The attached patch fixes this problem.
Thanks to dman for the fix, posted at http://drupal.org/node/325132#comment-1528052
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | taxonomy-link_query_fragment-632646-8.patch | 1 KB | agileware |
| #6 | taxonomy_link_query_fragment-632646-6.patch | 1.18 KB | agileware |
| taxonomy_link_query_fragment.patch | 1.08 KB | agileware |
Comments
Comment #1
agileware commentedtaxonomy_link is no longer in drupal 7 so this doesn't need porting to 7
Comment #2
dman commented+1 on this. Fixes a problem.
Although it's so late now (though the issue was a year and a half old) I don't hold high hopes for anyone bothering to fix it in core D6. :-(
Would need a test and stuff.
Comment #4
agileware commentedI have checked the patch and it still applies cleanly to the current cvs version.
When I get some time over the next couple of weeks I will learn how to write tests and give that a go.
Comment #5
dman commentedtestbot failed because the patch included your path 'drupal-6.x-dev'.
Need to build it from inside drupalroot IIRC
Comment #6
agileware commentedHere is the same patch created against cvs from inside the drupal root.
Weird though, I though as long as it applied with patch -p0 it would be ok.
Comment #8
agileware commentedOK, since we have moved to git I'll have one more try to get this to work.
This one is the same patch made with git.
Comment #9
dman commentedHell yeah, let me unpatch core.