See #537828: Help text for core modules - update to conform to new standard meta-issue, and in particular, http://drupal.org/node/537828#comment-2264512 where it was requested to break patches into "chunks".

So here is a patch that fixes up the main module help screens for the field*, file, filter, locale, translation, and trigger modules to conform to the new standards. It also adds module help pages for a few of the modules that were previously missing help pages, edits some of the help text, and fixes some broken links.

CommentFileSizeAuthor
#7 632716.patch45.43 KBjhodgdon
#2 632716.patch45.42 KBjhodgdon
537828-jhodgdon.patch45.34 KBjhodgdon

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 632716.patch45.42 KB

Gracious! 12 hours old and already failed to apply? Sheesh!

Hmmm... I just did a CVS update and it applies fine for me. Anyway, I'm back to the usual place I roll patches from, and here's a rerolled patch and we'll see if the testing bot likes it any better.

arianek’s picture

arianek commented
Issue tags: +d7help

adding tag "d7help"

arianek’s picture

arianek commented
Status: Needs review » Needs work

hey - i was just looking at your patch for reference and noticed a missing t() in filter module:

+ $output .= '<dt>Filters and text formats</dt>';

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Good catch! Sorry for forgetting the issue tag too.

arianek’s picture

arianek commented

I think you posted it before I made the convention ;-) - and just fyi, I didn't do a proper patch review here, so it still needs review before RTBCing!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 632716.patch45.43 KB

Here's a new version with t() added to that line.

lisarex’s picture

lisarex commented

Arianek and I decided to split up this massive patch into a new issue/patch per module. Any patch that changes 12 different files is too much work and no one is going to be v. keen to review/reroll, and the deadline is Dec 1st.

#645776: Help File Fixup: field

#645778: Help File Fixup: Field UI

#645784: Help File Fixup: Filter

#645790: Help File Fixup: Locale and Translation

#645796: Help File Fixup: Trigger

arianek’s picture

arianek commented
Status: Needs review » Closed (duplicate)

thanks lisarex!!!!! after the patches have been posted, let's just mark this as a duplicate

arianek’s picture

arianek commented
Status: Closed (duplicate) » Needs work

oopsie

arianek’s picture

arianek commented

one more, i found stuff for file.module in the patch: #645802: Help File Fixup: File module

arianek’s picture

arianek commented
Status: Needs work » Closed (duplicate)

ok, i just manually cut apart the big patch (i didn't know how else to go about it) - marking this as duplicate now.